From: Eric Sandeen <sandeen@redhat.com>
To: Keith Mannthey <kmannth@us.ibm.com>
Cc: Lukas Czerner <lczerner@redhat.com>, Tao Ma <tm@tao.ma>,
linux-ext4@vger.kernel.org
Subject: Re: Quick EXT4 discard question
Date: Sat, 23 Apr 2011 09:23:34 -0500 [thread overview]
Message-ID: <4DB2E0E6.8030302@redhat.com> (raw)
In-Reply-To: <1303488500.1389.139.camel@keith-laptop>
On 4/22/11 11:08 AM, Keith Mannthey wrote:
> On Fri, 2011-04-22 at 09:44 +0200, Lukas Czerner wrote:
...
>> Actually you can query that with hdparm -I /path/to/the/device and you
>> should see something like
>>
>> * Data Set Management TRIM supported
>>
>> in the output.
>
> I see
>
> * Data Set Management TRIM supported
> ...
> * Deterministic read after TRIM
>
> set on my devices.
>
> Thanks,
> Keith
So the way you get your message is:
ret = ext4_issue_discard(sb, entry->group,
entry->start_blk, entry->count);
if (unlikely(ret == -EOPNOTSUPP)) {
ext4_warning(sb, "discard not supported, "
"disabling");
clear_opt(sb, DISCARD);
}
which returns the error message from the calls below it:
ext4_issue_discard
sb_issue_discard
blkdev_issue_discard
and EOPNOTSUPP is pretty clear... I wonder if it could be that a discard request
on a particular boundary is causing it to be rejected?
-Eric
next prev parent reply other threads:[~2011-04-23 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 0:45 Quick EXT4 discard question Keith Mannthey
2011-04-22 2:27 ` Tao Ma
2011-04-22 2:44 ` Keith Mannthey
2011-04-22 2:53 ` Tao Ma
2011-04-22 7:44 ` Lukas Czerner
2011-04-22 8:31 ` Tao Ma
2011-04-22 16:08 ` Keith Mannthey
2011-04-23 14:23 ` Eric Sandeen [this message]
2011-04-22 19:59 ` Greg Freemyer
-- strict thread matches above, loose matches on Subject: below --
2011-04-23 6:41 Girish Shilamkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB2E0E6.8030302@redhat.com \
--to=sandeen@redhat.com \
--cc=kmannth@us.ibm.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).