From: Eric Sandeen <sandeen@redhat.com>
To: Zhao Cai <zhaocai@me.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
ext4 mailing list <linux-ext4@vger.kernel.org>
Subject: Re: ext4_put_super is not called during system shutdown or restart
Date: Mon, 25 Apr 2011 15:18:29 -0500 [thread overview]
Message-ID: <4DB5D715.3040809@redhat.com> (raw)
In-Reply-To: <05B9E852-8558-4A57-B386-E29EBC16595C@me.com>
On 4/25/11 3:07 PM, Zhao Cai wrote:
> In that case, how to make sure all the jbd2 transactions are fininshed before reboot? is it ext4_freeze and jbd2_journal_flush?
the remount readonly path should do this, I think.
ext4_remount
ext4_mark_recovery_complete
jbd2_journal_lock_updates
jbd2_journal_flush
-Eric
> Thanks.
> --
> All the best,
>
> Zhao Cai
>
>
> On Apr 25, 2011, at 12:12 PM, Zhao Cai wrote:
>
>> On Apr 25, 2011, at 12:10 PM, Eric Sandeen wrote:
>>
>>> On 4/25/11 11:05 AM, Zhao Cai wrote:
>>>> Sorry, my mistake. It happens only when ext4 is the root file system.
>>>
>>> that makes sense, since root is never actually unmounted; it just goes to readonly.
>>>
>>> -Eric
>>
>> Thanks. That means it is designed to be like this!
>>
>>>> -Zhao
>>>>
>>>>
>>>> On Apr 25, 2011, at 11:02 AM, Amir Goldstein wrote:
>>>>
>>>>> On Monday, April 25, 2011, Eric Sandeen <sandeen@redhat.com> wrote:
>>>>>> On 4/24/11 11:12 PM, Zhao Cai wrote:
>>>>>>> I would appreciate if anyone can give me an answer. Is it designed to
>>>>>>> be like this?
>>>>>>>
>>>>>>> Detailed situation: The system is ubuntu 11.04 installed in VMware. I
>>>>>>> notice that ext4_put_super() is called when I unmount a non-root ext4
>>>>>>> partition. But it is not when I restart or shutdown the system.
>>>>>>
>>>>>> Even for a non-root filesystem?
>>>>>>
>>>>>> I don't know if ubuntu does anything special, but I would expect that during a system shutdown, non-root filesystems would be unmounted, and you'd get put_super called. Unless the fs is busy and it can't be unmounted for some reason...
>>>>>
>>>>> This strangely reminds me of my report that xfstests sometimes fails
>>>>> to umount on Ubuntu 10.10.
>>>>> But I could be just trying to hold on to the hope of somebody else
>>>>> solving my problems...
>>>>>
>>>>>>
>>>>>> -Eric
>>>>>>
>>>>>>> Thanks。
>>>>>>>
>>>>>>> -- All the best,
>>>>>>>
>>>>>>> Zhao Cai
>>>>>>>
>>>>>>>
>>>>>>> -- To unsubscribe from this list: send the line "unsubscribe
>>>>>>> linux-ext4" in the body of a message to majordomo@vger.kernel.org
>>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>
>>>>>> --
>>>>>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>>>>>> the body of a message to majordomo@vger.kernel.org
>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>
>>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-25 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 4:12 ext4_put_super is not called during system shutdown or restart Zhao Cai
2011-04-25 14:26 ` Eric Sandeen
2011-04-25 15:02 ` Amir Goldstein
2011-04-25 16:05 ` Zhao Cai
2011-04-25 16:10 ` Eric Sandeen
2011-04-25 16:12 ` Zhao Cai
2011-04-25 20:07 ` Zhao Cai
2011-04-25 20:18 ` Eric Sandeen [this message]
2011-04-25 20:43 ` Zhao Cai
2011-04-25 18:23 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB5D715.3040809@redhat.com \
--to=sandeen@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=zhaocai@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).