Re: [PATCH RFC v1 0/5]Factor common code from convert and split unwritten.

[Allison Henderson <achender@linux.vnet.ibm.com>]

On 4/27/2011 11:05 PM, Yongqiang Yang wrote:
> Hi Allison,
>
> Could you send punch hole patch and fsx(if you modified it) to me?  I
> can not reproduce the bug on my system without punch hole.
>
> Thank you,
> Yongqiang.
>

Sure, I have a patch for fsx to enable fallocate, and another patch that 
adds punch hole to the test suite.  Right now I'm just working on
  getting our patches through the fsx that only has fallocate enabled. 
I thought it might be best if we work out all the bugs with that first 
before we deal with the more complex tests.

Also, I have a debug patch that fits on top of the punch hole patch. 
Initially I hadn't planned to send it out, but maybe it might help you 
so I will include it too.

Allison Henderson

> On Wed, Apr 27, 2011 at 2:34 PM, Allison Henderson
> <achender@linux.vnet.ibm.com>  wrote:
>> On 4/26/2011 9:48 PM, Yongqiang Yang wrote:
>>>
>>> On Wed, Apr 27, 2011 at 3:08 AM, Allison Henderson
>>> <achender@linux.vnet.ibm.com>    wrote:
>>>>
>>>> On 4/23/2011 1:44 AM, Yongqiang Yang wrote:
>>>>>
>>>>> v0->v1:
>>>>>     fix a bug in ext4_ext_convert_to_initialized() reported by
>>>>>     Allison<achender@linux.vnet.ibm.com>.
>>>>>
>>>>>     optimize ext4_ext_convert_to_initialized().
>>>>>
>>>>> -- factor common code
>>>>>     These patches factor common code from
>>>>> ext4_ext_convert_to_initialized()
>>>>> and
>>>>>     ext4_split_unwritten_extents() so that extent-move-on-write in
>>>>> snapshot
>>>>> and
>>>>>     punch hole can be built on the common code.
>>>>>
>>>>> -- optimization
>>>>>     the 4th and the 5th patch optimize ext4_ext_convert_to_initialized()
>>>>> by
>>>>>     zeroing out in memory.
>>>>>
>>>>>
>>>>> [PATCH RFC v1 1/5] ext4:Add a function merging extent right and left.
>>>>> [PATCH RFC v1 2/5] ext4:Add two functions splitting an extent.
>>>>> [PATCH RFC v1 3/5] ext4:Reimplement convert and split_unwritten.
>>>>> [PATCH RFC v1 4/5] ext4: Add a function ext4_ext_zeroout_mem().
>>>>> [PATCH RFC v1 5/5] ext4: optimize ext4_ext_convert_to_initialized().
>>>>> --
>>>>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>>>>> the body of a message to majordomo@vger.kernel.org
>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>
>>>> Hi there,
>>>>
>>>> Just an update on your patch set.  Im am working on getting the punch
>>>> hole
>>>> patch to work with this new set, but I'm am having trouble getting it
>>>> through the stress test.  It gets up to around 48265 file operations, and
>>>> then hangs. So I am currently trying to narrow down the problem.  It
>>>> looks
>>>> like it does it with or with out the extra punch hole patches, but you
>>>> may
>>>> need to enable fallocate in the fsx Makefile to recreate the problem.  I
>>>> will keep you posted if I find any more clues.
>>>
>>> Hi,
>>>
>>> Could you tell me how to get fsx?  I can not find that.
>>
>> Hi there,
>>
>> I believe you can find it in both xfstests and ltp.  The one I am using I
>> got from xfstests here:
>>
>> http://xfs.org/index.php/Getting_the_latest_source_code
>>
>> Once you have it configured and built, there is a sub folder called ltp.
>>   Execute this command from that folder:
>>
>> ./fsx -d -b 1 -N 100000 -S 1 /mnt/ext4MntPt/holePunch/testFile
>>
>> Where "/mnt/ext4MntPt/holePunch/testFile" is a file on an ext4 file system.
>>   It should then try to run through 100000 random file operations, but get
>> stuck on number 48256.
>>
>> If you do not see any fallocate operations running, you may have to go
>> enable it in the ltp/Makefile.  I had to change "ifeq ($(HAVE_FALLOCATE),
>> true)" to "ifeq ($(HAVE_FALLOCATE), yes)" to allow the extra fallocate code
>> to compile in.  Let me know if you have any trouble recreating the bug.
>>
>>>
>>> Thank you,
>>> Yongqiang.
>>>>
>>>> Allison Henderson
>>>>
>>>
>>>
>>>
>>
>>
>
>
>