From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] debugfs: remove unused htree_dump "-l" argument
Date: Wed, 11 May 2011 11:46:19 -0500 [thread overview]
Message-ID: <4DCABD5B.8040403@redhat.com> (raw)
The long_opt / -l argument was apparently never implemented,
so remove it and associated argument parsing.
This slightly changes the (undocumented) behavior because it
no longer defaults to cwd if no filespec is specified...
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/debugfs/htree.c b/debugfs/htree.c
index 08f9749..b829e25 100644
--- a/debugfs/htree.c
+++ b/debugfs/htree.c
@@ -197,8 +197,6 @@ void do_htree_dump(int argc, char *argv[])
{
ext2_ino_t ino;
struct ext2_inode inode;
- int c;
- int long_opt = 0;
blk64_t blk;
char *buf = NULL;
struct ext2_dx_root_info *rootnode;
@@ -211,28 +209,7 @@ void do_htree_dump(int argc, char *argv[])
pager = open_pager();
- reset_getopt();
- while ((c = getopt (argc, argv, "l")) != EOF) {
- switch (c) {
- case 'l':
- long_opt++;
- break;
- default:
- goto print_usage;
- }
- }
-
- if (argc > optind+1) {
- print_usage:
- com_err(0, 0, "Usage: htree_dump [-l] file");
- goto errout;
- }
next reply other threads:[~2011-05-11 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 16:46 Eric Sandeen [this message]
2011-05-12 7:43 ` [PATCH] debugfs: remove unused htree_dump "-l" argument Lukas Czerner
2011-05-15 3:39 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCABD5B.8040403@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).