From: Allison Henderson <achender@linux.vnet.ibm.com>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Yongqiang Yang <xiaoqiangnk@gmail.com>,
Mingming Cao <cmm@us.ibm.com>, Theodore Tso <tytso@mit.edu>
Subject: [PATCH v2] ext4: ext4_ext_convert_to_initialized bug found in extended FSX testing
Date: Fri, 13 May 2011 23:03:05 -0700 [thread overview]
Message-ID: <4DCE1B19.9070503@linux.vnet.ibm.com> (raw)
Hi all,
After applying this patch, the fsx test has been able to run ok all
day (about 12hrs). So I think it's safe to send it out now. Thx all!
Allison Henderson
Signed-off-by: Allison Henderson <achender@us.ibm.com>
---
:100644 100644 e363f21... 5f243da... M fs/ext4/extents.c
fs/ext4/extents.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index e363f21..5f243da 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2818,8 +2818,8 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,
(EXT4_EXT_MAY_ZEROOUT & split_flag)) {
/* case 3 */
zero_ex.ee_block =
- cpu_to_le32(map->m_lblk + map->m_len);
- zero_ex.ee_len = cpu_to_le16(allocated - map->m_len);
+ cpu_to_le32(map->m_lblk);
+ zero_ex.ee_len = cpu_to_le16(allocated);
ext4_ext_store_pblock(&zero_ex,
ext4_ext_pblock(ex) + map->m_lblk - ee_block);
err = ext4_ext_zeroout(inode, &zero_ex);
@@ -2842,10 +2842,9 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,
goto out;
}
- allocated = map->m_lblk - ee_block + map->m_len;
next reply other threads:[~2011-05-14 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 6:03 Allison Henderson [this message]
2011-05-16 15:09 ` [PATCH v2] ext4: ext4_ext_convert_to_initialized bug found in extended FSX testing Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCE1B19.9070503@linux.vnet.ibm.com \
--to=achender@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).