From: Manish Katiyar <mkatiyar@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] jbd2 : Fix journal start by passing a parameter to specify if the caller can deal with ENOMEM
Date: Wed, 25 May 2011 00:47:06 -0700 [thread overview]
Message-ID: <4DDCB3FA.2070009@gmail.com> (raw)
In-Reply-To: <20110525074457.GA4427@quack.suse.cz>
On 05/25/2011 12:44 AM, Jan Kara wrote:
> This patch is OK as such but as I wrote in a reply to a later patch in
> the series, you also need to pass 'errok' to start_this_handle() instead of
> gfp_mask as well. Then in start_this_handle() you can use 'errok' to decide
> whether we should retry the allocation or not instead of gfp_mask. And just
> call kzalloc in start_this_handle() with GFP_NOFS... Thanks.
Hi Jan,
ok.. I will do it as a separate patch.
--
Thanks -
Manish
next prev parent reply other threads:[~2011-05-25 7:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 7:26 [PATCH 2/3] jbd2 : Fix journal start by passing a parameter to specify if the caller can deal with ENOMEM Manish Katiyar
2011-05-25 7:44 ` Jan Kara
2011-05-25 7:47 ` Manish Katiyar [this message]
2011-05-25 8:13 ` Jan Kara
2011-05-26 2:22 ` Ted Ts'o
2011-05-26 4:07 ` Andreas Dilger
2011-05-26 14:05 ` Ted Ts'o
2011-05-26 14:49 ` Jan Kara
2011-05-26 15:08 ` Ted Ts'o
2011-05-26 15:37 ` Jan Kara
2011-05-27 4:11 ` Manish Katiyar
2011-05-26 5:29 ` Manish Katiyar
2011-05-26 14:51 ` Jan Kara
2011-05-28 6:16 ` Manish Katiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCB3FA.2070009@gmail.com \
--to=mkatiyar@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).