From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
mitchb@mit.edu, Bruce Cassidy <bruce@whamcloud.com>
Subject: Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
Date: Thu, 16 Jun 2011 15:39:07 -0500 [thread overview]
Message-ID: <4DFA69EB.3060907@redhat.com> (raw)
In-Reply-To: <4D84C5C9.1060507@redhat.com>
On 3/19/11 10:03 AM, Eric Sandeen wrote:
> On 2/20/11 5:10 PM, Ted Ts'o wrote:
>> On Wed, Feb 16, 2011 at 12:01:39PM -0600, Eric Sandeen wrote:
>>> After debian bug #192277, debian/rules started making a symlink
>>> to com_err.h in /usr/include. Now I have Fedora bug #550889
>>> for the same issue, and perhaps it's time to make this symlink
>>> by default, rather than fixing it up in packaging steps?
>>>
>>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>>
>> Pulled into the e2fsprogs tree, with the following change:
>>
>> [ Changed by tytso to remove the explicit -s option; this will
>> default to creating a hard link by default, which slightly faster.
>> If people want to use symlinks for all links during the install
>> process, they can use configure option --enable-symlink-install.
>> The reason for this change is that some file systems, like AFS,
>> don't support symlinks, and AFS users complain when they can't build
>> or install into AFS. So I don't want to use symlinks
>> unconditionally without a way of switching things back and forth,
>> and it's easier if we just make all links made during the install
>> process to be hard links or sym links. ]
>>
>>
>> - Ted
>
> Hm, now in a "make rpm" build which has source in one place and rpm build
> area in another:
>
> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>
> so I'm not quite sure how to work around this.
>
> Maybe in the end it does have to be packaging-specific, with the
> link created by the distro pkg scripts...?
Ted, your change broke any builds span 2 different filesystems.
Now what?
-Eric
next prev parent reply other threads:[~2011-06-16 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 18:01 [PATCH] e2fsprogs: create com_err.h symlink in includedir Eric Sandeen
2011-02-20 23:10 ` Ted Ts'o
2011-03-19 15:03 ` Eric Sandeen
2011-06-16 20:39 ` Eric Sandeen [this message]
2011-06-17 2:31 ` Ted Ts'o
2011-06-17 3:54 ` Andreas Dilger
2011-06-17 14:27 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFA69EB.3060907@redhat.com \
--to=sandeen@redhat.com \
--cc=bruce@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mitchb@mit.edu \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).