From: Eric Sandeen <sandeen@redhat.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] e2fsck: fix error in computing blocks of the ending group
Date: Thu, 21 Jul 2011 12:40:35 -0500 [thread overview]
Message-ID: <4E286493.6050709@redhat.com> (raw)
In-Reply-To: <4E25AE6A.6090909@redhat.com>
On 7/19/11 11:18 AM, Eric Sandeen wrote:
> On 07/19/2011 10:46 AM, Yongqiang Yang wrote:
>> If the blocks of a filesystem is a multiple of blocks_per_group,
>> blocks of the ending group is computed wrongly. This patch computes
>> it by substracting blocks processed from blocks of the filesystem.
>>
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
>> ---
>> e2fsck/pass5.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/e2fsck/pass5.c b/e2fsck/pass5.c
>> index f9d746c..7c4e336 100644
>> --- a/e2fsck/pass5.c
>> +++ b/e2fsck/pass5.c
>> @@ -227,7 +227,7 @@ redo_counts:
>> if (group == (int)fs->group_desc_count - 1)
>> cmp_block =
>> EXT2FS_NUM_B2C(fs,
>> - ext2fs_blocks_count(fs->super) % fs->super->s_blocks_per_group);
>> + ext2fs_blocks_count(fs->super) - i);
>> }
>>
>> bitmap = 0;
>
> I think it would be clearer to just get the last group block count from
> superblock information, rather than from using the loop counter.
Actually I see that I misread this... here we are dealing with
clusters per group and my proposed blocks per group helper won't help.
Sorry for the noise, I think your patch should go in as proposed.
I'll still send my helper, but I don't think it will help in this
location, and your patch is correct.
-Eric
next prev parent reply other threads:[~2011-07-21 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 15:46 [PATCH] e2fsck: fix error in computing blocks of the ending group Yongqiang Yang
2011-07-19 16:18 ` Eric Sandeen
2011-07-20 21:46 ` [PATCH] e2fsprogs: add ext2fs_group_blocks_count helper Eric Sandeen
2011-07-20 21:57 ` [PATCH V2] " Eric Sandeen
2011-07-21 13:55 ` Eric Sandeen
2011-07-21 14:57 ` Yongqiang Yang
2011-07-21 15:06 ` Eric Sandeen
2011-07-21 18:15 ` [PATCH V3] " Eric Sandeen
2011-09-16 13:22 ` [V3] " Ted Ts'o
2011-07-21 14:54 ` [PATCH] " Yongqiang Yang
2011-07-21 17:40 ` Eric Sandeen [this message]
2011-07-22 4:18 ` [PATCH V2] e2fsck: fix error in computing blocks of the ending group Eric Sandeen
2011-09-16 13:29 ` [V2] " Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E286493.6050709@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).