From: Tao Ma <tm@tao.ma>
To: Ted Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Check extent overflow with the right range.
Date: Tue, 18 Oct 2011 10:27:32 +0800 [thread overview]
Message-ID: <4E9CE414.9040706@tao.ma> (raw)
In-Reply-To: <20111017141605.GA25017@thunk.org>
Hi Ted,
On 10/17/2011 10:16 PM, Ted Ts'o wrote:
> On Mon, Oct 17, 2011 at 04:45:28PM +0800, Tao Ma wrote:
>> From: Tao Ma <boyu.mt@taobao.com>
>>
>> In 4fd30c033, we move the range check before we change ix to avoid the memory stamp.
>> But actually we should check against the EXT_MAX_INDEX, not EXT_LAST_INDEX.
>>
>> So this patch revert the old patch and adds a new check before we setting ix.
>>
>> Cc: "Theodore Ts'o" <tytso@mit.edu>
>> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
>> ---
>> Ted, since 4fd30c033 is in your dev branch, I am fine to integrate these 2 patches to one.
>
>
> Hi Tao,
>
> I have integrated this with the the existing patch in dev branch (since
> it isn't in the master branch yet, and hence hasn't been locked down).
>
> I'm wondering though how you originally ran into this case, though.
> If there is no more room in the tree node, we should have never
> entered ext4_ext_extent_index() in the first place. Was this a
> theoretical concern or did you actually see this happen. And if so,
> was it due to a file system corruption, or another bug someplace else.
We have met with some corruption, but not sure whether it is related to
this or not. To be honest, we went through the code and find that this
may be a possible cause. So if you think it could never happen, we are
OK to drop this patch.
Thanks
Tao
next prev parent reply other threads:[~2011-10-18 2:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 6:57 corruption on 3.1.0-rc9-next-20111011+ Dan Carpenter
2011-10-17 8:10 ` Dan Carpenter
2011-10-17 8:45 ` [PATCH] ext4: Check extent overflow with the right range Tao Ma
2011-10-17 9:10 ` Yongqiang Yang
2011-10-17 14:16 ` Ted Ts'o
2011-10-18 2:27 ` Tao Ma [this message]
2011-10-18 15:07 ` Ted Ts'o
2011-10-17 8:51 ` corruption on 3.1.0-rc9-next-20111011+ Tao Ma
2011-10-17 9:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9CE414.9040706@tao.ma \
--to=tm@tao.ma \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).