From: Tao Ma <tm@tao.ma>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Ted Ts'o <tytso@mit.edu>,
ext4 development <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH V1 00/17] ext4: Add inline data support.
Date: Wed, 26 Oct 2011 16:17:01 +0800 [thread overview]
Message-ID: <4EA7C1FD.3090907@tao.ma> (raw)
In-Reply-To: <CAOQ4uxgpkd5WwwwkuxTupYRS-2Nf7mu=V5JCO2CTYQN3k0BCCg@mail.gmail.com>
On 10/26/2011 04:05 PM, Amir Goldstein wrote:
>
>
> On Wed, Oct 26, 2011 at 9:32 AM, Tao Ma <tm@tao.ma <mailto:tm@tao.ma>>
> wrote:
>
> Hi Ted, Andreas and list,
> This is my 1st attempt to add inline data support to ext4
> inode. For
> more information about the background, please refer to the thread
> http://marc.info/?l=linux-ext4&m=131715205428067&w=2
> <http://marc.info/?l=linux-ext4&m=131715205428067&w=2>
> When I sent out the RFC on Sep.27, Andreas suggested that we can use the
> space of xattr to put inline data. So this is the 1st version using that
> method. It should be easy to change if we decide to use other places in
> inode(e.g the unused extent space) since all the inline data
> manipulation function is wrapped with function like ext4_*_inline_data.
>
> Currently I use all the space between i_extra_isize and inode_size if
> inode_size = 256. For inode_size > 256, half of that space is used so as
> to leave some space for other xattrs.
>
> This is only a V1 and there are still something to do(e.g. I am thinking
> of using unused extent space), but I'd like to send it out earlier so
> that it can be reviewed ASAP.
>
> Some simple tests shows that with a linux-3.0 vanilla source, the new
> dir can save 1% disk space. For my "/usr", it can save about 3.2%
> spaces. I guess for volume with future bigalloc support, it should save
> more space for us for small dir. I also run some other tests and it
> seems the code is OK for a try. I haven't found a good test cases that
> can test the small file/dir(tens of bytes in my case) performance where
> inline data should have some good number.
>
> Any comments are welcomed.
>
> git diff --stat
>
> fs/ext4/dir.c | 117 ++++++++++-
> fs/ext4/ext4.h | 15 +-
> fs/ext4/ialloc.c | 4 +
> fs/ext4/inode.c | 583
> +++++++++++++++++++++++++++++++++++++++++++++++---
>
>
> Hi Tao,
>
> One generic comment.
> how about adding a new file fs/ext4/inline.c to host inline data support
> related code?
> inode.c is too big as it is and there is an effort the size it down.
sure, I will try to separate related functions to inline.c in my V2.
Thanks
Tao
next prev parent reply other threads:[~2011-10-26 8:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 7:32 [PATCH V1 00/17] ext4: Add inline data support Tao Ma
2011-10-26 7:34 ` [PATCH V1 01/17] ext4: Move extra inode read to a new function Tao Ma
2011-10-26 7:34 ` [PATCH V1 02/17] ext4: Add the basic function for inline data support Tao Ma
2011-10-26 8:36 ` Andreas Dilger
2011-10-26 14:38 ` Tao Ma
2011-10-26 22:28 ` Andreas Dilger
2011-10-27 0:51 ` Tao Ma
2011-10-27 0:51 ` Tao Ma
2011-10-27 9:57 ` Andreas Dilger
2011-10-27 14:53 ` Tao Ma
2011-11-02 21:16 ` Andreas Dilger
2011-11-03 4:23 ` Tao Ma
2011-10-26 7:34 ` [PATCH V1 03/17] ext4: Add read support for inline data Tao Ma
2011-10-26 7:34 ` [PATCH V1 04/17] ext4: Add normal write " Tao Ma
2011-10-26 7:34 ` [PATCH V1 05/17] ext4: Add journalled " Tao Ma
2011-10-26 7:34 ` [PATCH V1 06/17] ext4: Add delalloc " Tao Ma
2011-10-26 7:34 ` [PATCH V1 07/17] ext4: Create a new function ext4_init_new_dir Tao Ma
2011-10-26 7:34 ` [PATCH V1 08/17] ext4: Refactor __ext4_check_dir_entry to accepts start and size Tao Ma
2011-10-26 7:34 ` [PATCH V1 09/17] ext4: Create __ext4_insert_dentry for dir entry insertion Tao Ma
2011-10-26 7:34 ` [PATCH V1 10/17] ext4: let add_dir_entry handle inline data properly Tao Ma
2011-10-26 7:34 ` [PATCH V1 11/17] ext4: Let ext4_readdir handle inline data Tao Ma
2011-10-26 7:34 ` [PATCH V1 12/17] ext4: Create a new function search_dir Tao Ma
2011-10-26 7:34 ` [PATCH V1 13/17] ext4: let ext4_find_entry handle inline data Tao Ma
2011-10-26 7:34 ` [PATCH V1 14/17] ext4: let ext4_delete_entry " Tao Ma
2011-10-26 7:34 ` [PATCH V1 15/17] ext4: let empty_dir handle inline dir Tao Ma
2011-10-26 7:34 ` [PATCH V1 16/17] ext4: let ext4_rename " Tao Ma
2011-10-26 7:34 ` [PATCH V1 17/17] ext4: Enable ext4 inline support Tao Ma
[not found] ` <CAOQ4uxgpkd5WwwwkuxTupYRS-2Nf7mu=V5JCO2CTYQN3k0BCCg@mail.gmail.com>
2011-10-26 8:17 ` Tao Ma [this message]
2011-10-27 7:10 ` [PATCH V1 00/17] ext4: Add inline data support Valdis.Kletnieks
2011-10-27 13:54 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA7C1FD.3090907@tao.ma \
--to=tm@tao.ma \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).