From: Allison Henderson <achender@linux.vnet.ibm.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 0/7] ext4: cleanups and regression fixes for grow/shrink logic V3
Date: Wed, 02 Nov 2011 16:12:24 -0700 [thread overview]
Message-ID: <4EB1CE58.9070200@linux.vnet.ibm.com> (raw)
In-Reply-To: <1319821210-7374-1-git-send-email-dmonakhov@openvz.org>
On 10/28/2011 10:00 AM, Dmitry Monakhov wrote:
> changes from v2 (in responce to comments from tytso@)
> - split punch_hole handler patch in to reviewable peaces.
> - redesign error path for ext4_ext_map_blocks
>
> ##First patch is a fix for real issue
> ext4: Restore old EOFBLOCKS flag state after error
> ##Code cleanup for shrink logic.
> ext4: move inode indepth shrink logic to didicated function
> ##The rest are punch hole logic fixes
> ext4: Move punch hole logic to didicated function
> ext4: punch_hole fix extent conversion
> ext4: Update inode's transaction id after punch_hole
> ext4: punch hole should be restarted after transaction restart
> ext4: update EOFBLOCK flags after punch hole
Hi Dmitry,
I went through this set, and I think it looks good. I didnt catch
anything that hasnt already been explained in earlier versions, and I
think it looks cleaner now. Thx!
Allison Henderson
prev parent reply other threads:[~2011-11-02 23:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 17:00 [PATCH 0/7] ext4: cleanups and regression fixes for grow/shrink logic V3 Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 1/7] ext4: Restore old EOFBLOCKS flag state after error Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 2/7] ext4: move inode indepth shrink logic to didicated function Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 3/7] ext4: Move punch hole " Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 4/7] ext4: punch_hole fix extent conversion Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 5/7] ext4: Update inode's transaction id after punch_hole Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 6/7] ext4: punch hole should be restarted after transaction restart Dmitry Monakhov
2011-10-28 17:00 ` [PATCH 7/7] ext4: update EOFBLOCK flags after punch hole Dmitry Monakhov
2011-11-02 23:12 ` Allison Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB1CE58.9070200@linux.vnet.ibm.com \
--to=achender@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).