Re: [PATCH] Set the initial TRIM information as TRIMMED

Tao Ma
2011-12-01T07:39:26Z

Hi Kyungmin,
On 12/01/2011 03:00 PM, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Now trim information doesn't stored at disk so every boot time. it's cleared.
> and do the trim all disk groups.
> But assume that it's already trimmed at previous time so don't need to trim it again. So set the intial state as trimmed.
sorry, I don't get your meaning here.
Why can we assume that the group is already trimmed since it isn't
stored in the disk?

Thanks
Tao
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index e2d8be8..97ef342 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1098,6 +1098,12 @@ int ext4_mb_init_group(struct super_block *sb, ext4_group_t group)
> goto err;
> }
> mark_page_accessed(page);
> +
> + /*
> + * TRIM information is not stored at disk so set the initial
> + * state as trimmed. Since previous time it's already trimmed all
> + */
> + EXT4_MB_GRP_SET_TRIMMED(this_grp);
> err:
> ext4_mb_put_buddy_page_lock(&e4b);
> return ret;