From: Allison Henderson <achender@linux.vnet.ibm.com>
To: Hugh Dickins <hughd@google.com>
Cc: "Ted Ts'o" <tytso@mit.edu>, Curt Wohlgemuth <curtw@google.com>,
Yongqiang Yang <xiaoqiangnk@gmail.com>,
Surbhi Palande <csurbhi@gmail.com>, Rafael Wysocki <rjw@sisk.pl>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Bug with "fix partial page writes" [3.2-rc regression]
Date: Mon, 05 Dec 2011 18:40:46 -0700 [thread overview]
Message-ID: <4EDD729E.2060402@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1112051456580.3938@sister.anvils>
On 12/05/2011 04:38 PM, Hugh Dickins wrote:
> On Mon, 21 Nov 2011, Hugh Dickins wrote:
>> On Mon, 21 Nov 2011, Ted Ts'o wrote:
>>> On Sun, Nov 20, 2011 at 12:59:10PM -0800, Hugh Dickins wrote:
>>>> On Tue, 8 Nov 2011, Curt Wohlgemuth wrote:
>>>> It appears that there's a bug with this patch:
>
> This has been outstanding for a month now, and we've heard no progress:
> please revert commit 02fac1297eb3 "ext4: fix partial page writes" for rc5.
>
> The problems appear on a 1k-blocksize filesystem under memory pressure:
> the hunk in ext4_da_write_end() causes oops, because it's playing with
> a page after generic_write_end() dropped our last reference to it; and
> backing out the hunk in ext4_da_write_begin() is then found to stop
> rare data corruption seen when kbuilding.
>
> Although I earlier reported that backing out the patch caused an fsx
> test to fail earlier, I've since found great variation in how soon it
> fails, and seen it fail just as quickly with 02fac1297eb3 still in.
> I also reported that I had to go back to 2.6.38 for fsx not to fail
> under memory pressure: you won't be surprised that that turned out to
> be because 2.6.38 defaults nomblk_io_submit but 2.6.39 mblk_io_submit.
>
> Thanks,
> Hugh
>
Hi there,
Have you tried Yongqiang's patch "[PATCH 1/2] ext4: let mpage_submit_io
works well when blocksize < pagesize" ? I have tried it and it does
seem to help, but I am still running into some failures that I am trying
to debug, but let please let us know if it helps the issues that you are
seeing. Thx!
Allison Henderson
next prev parent reply other threads:[~2011-12-06 1:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 22:59 Bug with "fix partial page writes" Curt Wohlgemuth
2011-11-20 20:59 ` Hugh Dickins
2011-11-21 1:59 ` Yongqiang Yang
2011-11-21 17:38 ` Allison Henderson
[not found] ` <CAMBkX3cfQ+XS7M5jvXmj8_rBOJ_Afy+YXL7Roj+fswLqBA7i1Q@mail.gmail.com>
2011-11-21 21:26 ` Fwd: " Surbhi Palande
2011-11-22 15:57 ` Allison Henderson
2011-11-22 1:44 ` Yongqiang Yang
2011-11-21 16:56 ` Ted Ts'o
2011-11-21 22:04 ` Hugh Dickins
2011-12-05 23:38 ` Bug with "fix partial page writes" [3.2-rc regression] Hugh Dickins
2011-12-06 1:40 ` Allison Henderson [this message]
2011-12-06 3:08 ` Yongqiang Yang
2011-12-06 3:20 ` Yongqiang Yang
2011-12-06 3:33 ` Tao Ma
2011-12-06 3:44 ` Yongqiang Yang
2011-12-06 4:05 ` Allison Henderson
2011-12-06 7:57 ` Yongqiang Yang
2011-12-06 8:55 ` Hugh Dickins
2011-12-06 9:32 ` Yongqiang Yang
2011-12-06 22:31 ` Hugh Dickins
2011-12-06 21:15 ` Allison Henderson
2011-12-06 22:47 ` Hugh Dickins
2011-12-07 8:28 ` Yongqiang Yang
2011-12-07 17:04 ` Allison Henderson
2011-12-08 5:10 ` Allison Henderson
2011-12-08 17:39 ` Hugh Dickins
2011-12-08 18:12 ` Andy Whitcroft
2011-12-09 13:33 ` Andy Whitcroft
2011-12-09 13:44 ` Yongqiang Yang
2011-12-09 16:37 ` Allison Henderson
2011-12-14 4:12 ` Ted Ts'o
2011-12-14 18:07 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDD729E.2060402@linux.vnet.ibm.com \
--to=achender@linux.vnet.ibm.com \
--cc=csurbhi@gmail.com \
--cc=curtw@google.com \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tytso@mit.edu \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).