* [PATCH 1/6] ext2: fix up error handling for insert_inode_locked
[not found] <4EDE9D54.1030506@redhat.com>
@ 2011-12-06 22:57 ` Eric Sandeen
2011-12-06 23:18 ` [PATCH 1/6 v2] " Eric Sandeen
2011-12-06 22:59 ` [PATCH 2/6] ext3: " Eric Sandeen
2011-12-06 23:02 ` [PATCH 3/6] ext4: " Eric Sandeen
2 siblings, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2011-12-06 22:57 UTC (permalink / raw)
To: linux-fsdevel@vger.kernel.org; +Cc: ext4 development
after 250df6ed274d767da844a5d9f05720b804240197
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set. However, the error
handler still calls unlock_new_inode() on failure, which does a
WARN_ON if I_NEW is not set, so any failure spews a lot of
warnings.
(We also were doing dquot_drop, etc before we had initialized
the inode, that gets skipped as well)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index c4e81df..769351a 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -574,7 +574,7 @@ got:
spin_unlock(&sbi->s_next_gen_lock);
if (insert_inode_locked(inode) < 0) {
err = -EINVAL;
- goto fail_drop;
+ goto fail_put;
}
dquot_initialize(inode);
@@ -601,8 +601,9 @@ fail_free_drop:
fail_drop:
dquot_drop(inode);
inode->i_flags |= S_NOQUOTA;
- clear_nlink(inode);
unlock_new_inode(inode);
+fail_put:
+ clear_nlink(inode);
iput(inode);
return ERR_PTR(err);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 1/6 v2] ext2: fix up error handling for insert_inode_locked
2011-12-06 22:57 ` [PATCH 1/6] ext2: fix up error handling for insert_inode_locked Eric Sandeen
@ 2011-12-06 23:18 ` Eric Sandeen
0 siblings, 0 replies; 6+ messages in thread
From: Eric Sandeen @ 2011-12-06 23:18 UTC (permalink / raw)
Cc: linux-fsdevel@vger.kernel.org, ext4 development
after 250df6ed274d767da844a5d9f05720b804240197
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set on failure. However,
the error handler still calls unlock_new_inode() on failure,
which does a WARN_ON if I_NEW is not set, so any failure spews
a lot of warnings.
(We also were doing dquot_drop, etc before we had initialized
the quota, that gets skipped as well)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: don't rearrange clear_nlink, and edit commit message.
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index c4e81df..06cbc22 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -574,7 +574,7 @@ got:
spin_unlock(&sbi->s_next_gen_lock);
if (insert_inode_locked(inode) < 0) {
err = -EINVAL;
- goto fail_drop;
+ goto fail_put;
}
dquot_initialize(inode);
@@ -603,6 +603,7 @@ fail_drop:
inode->i_flags |= S_NOQUOTA;
clear_nlink(inode);
unlock_new_inode(inode);
+fail_put:
iput(inode);
return ERR_PTR(err);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/6] ext3: fix up error handling for insert_inode_locked
[not found] <4EDE9D54.1030506@redhat.com>
2011-12-06 22:57 ` [PATCH 1/6] ext2: fix up error handling for insert_inode_locked Eric Sandeen
@ 2011-12-06 22:59 ` Eric Sandeen
2011-12-06 23:19 ` [PATCH 2/6 V2] " Eric Sandeen
2011-12-06 23:02 ` [PATCH 3/6] ext4: " Eric Sandeen
2 siblings, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2011-12-06 22:59 UTC (permalink / raw)
To: linux-fsdevel@vger.kernel.org; +Cc: ext4 development
after 250df6ed274d767da844a5d9f05720b804240197
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set. However, the error
handler still calls unlock_new_inode() on failure, which does a
WARN_ON if I_NEW is not set, so any failure spews a lot of
warnings.
(We also were doing dquot_drop, etc before we had initialized
the quota, that gets skipped as well)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c
index 5c866e0..7d0493b 100644
--- a/fs/ext3/ialloc.c
+++ b/fs/ext3/ialloc.c
@@ -526,7 +526,7 @@ got:
handle->h_sync = 1;
if (insert_inode_locked(inode) < 0) {
err = -EINVAL;
- goto fail_drop;
+ goto fail_put;
}
spin_lock(&sbi->s_next_gen_lock);
inode->i_generation = sbi->s_next_generation++;
@@ -582,8 +582,9 @@ fail_free_drop:
fail_drop:
dquot_drop(inode);
inode->i_flags |= S_NOQUOTA;
- clear_nlink(inode);
unlock_new_inode(inode);
+fail_put:
+ clear_nlink(inode);
iput(inode);
brelse(bitmap_bh);
return ERR_PTR(err);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/6 V2] ext3: fix up error handling for insert_inode_locked
2011-12-06 22:59 ` [PATCH 2/6] ext3: " Eric Sandeen
@ 2011-12-06 23:19 ` Eric Sandeen
0 siblings, 0 replies; 6+ messages in thread
From: Eric Sandeen @ 2011-12-06 23:19 UTC (permalink / raw)
To: linux-fsdevel@vger.kernel.org; +Cc: ext4 development
after 250df6ed274d767da844a5d9f05720b804240197
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set on failure. However,
the error handler still calls unlock_new_inode() on failure,
which does a WARN_ON if I_NEW is not set, so any failure spews
a lot of warnings.
(We also were doing dquot_drop, etc before we had initialized
the quota, that gets skipped as well)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: don't rearrange clear_nlink, and edit commit message.
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c
index 5c866e0..5563d99 100644
--- a/fs/ext3/ialloc.c
+++ b/fs/ext3/ialloc.c
@@ -526,7 +526,7 @@ got:
handle->h_sync = 1;
if (insert_inode_locked(inode) < 0) {
err = -EINVAL;
- goto fail_drop;
+ goto fail_put;
}
spin_lock(&sbi->s_next_gen_lock);
inode->i_generation = sbi->s_next_generation++;
@@ -584,6 +584,7 @@ fail_drop:
inode->i_flags |= S_NOQUOTA;
clear_nlink(inode);
unlock_new_inode(inode);
+fail_put:
iput(inode);
brelse(bitmap_bh);
return ERR_PTR(err);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/6] ext4: fix up error handling for insert_inode_locked
[not found] <4EDE9D54.1030506@redhat.com>
2011-12-06 22:57 ` [PATCH 1/6] ext2: fix up error handling for insert_inode_locked Eric Sandeen
2011-12-06 22:59 ` [PATCH 2/6] ext3: " Eric Sandeen
@ 2011-12-06 23:02 ` Eric Sandeen
2011-12-06 23:19 ` [PATCH 3/6 V2] " Eric Sandeen
2 siblings, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2011-12-06 23:02 UTC (permalink / raw)
To: linux-fsdevel@vger.kernel.org; +Cc: ext4 development
after 250df6ed274d767da844a5d9f05720b804240197
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set on failure. However,
the error handler still calls unlock_new_inode() on failure,
which does a WARN_ON if I_NEW is not set, so any failure spews
a lot of warnings.
(We also were doing dquot_drop, etc before we had initialized
the quota, that gets skipped as well)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 00beb4f..f00c19a 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -886,7 +886,7 @@ got:
ext4_handle_sync(handle);
if (insert_inode_locked(inode) < 0) {
err = -EINVAL;
- goto fail_drop;
+ goto fail_put;
}
spin_lock(&sbi->s_next_gen_lock);
inode->i_generation = sbi->s_next_generation++;
@@ -948,8 +948,9 @@ fail_free_drop:
fail_drop:
dquot_drop(inode);
inode->i_flags |= S_NOQUOTA;
- clear_nlink(inode);
unlock_new_inode(inode);
+fail_put:
+ clear_nlink(inode);
iput(inode);
brelse(inode_bitmap_bh);
return ERR_PTR(err);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/6 V2] ext4: fix up error handling for insert_inode_locked
2011-12-06 23:02 ` [PATCH 3/6] ext4: " Eric Sandeen
@ 2011-12-06 23:19 ` Eric Sandeen
0 siblings, 0 replies; 6+ messages in thread
From: Eric Sandeen @ 2011-12-06 23:19 UTC (permalink / raw)
To: linux-fsdevel@vger.kernel.org; +Cc: ext4 development
after 250df6ed274d767da844a5d9f05720b804240197
(fs: protect inode->i_state with inode->i_lock), insert_inode_locked()
no longer returns the inode with I_NEW set on failure. However,
the error handler still calls unlock_new_inode() on failure,
which does a WARN_ON if I_NEW is not set, so any failure spews
a lot of warnings.
(We also were doing dquot_drop, etc before we had initialized
the quota, that gets skipped as well)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: don't rearrange clear_nlink, and edit commit message.
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 00beb4f..1e0c3bf 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -886,7 +886,7 @@ got:
ext4_handle_sync(handle);
if (insert_inode_locked(inode) < 0) {
err = -EINVAL;
- goto fail_drop;
+ goto fail_put;
}
spin_lock(&sbi->s_next_gen_lock);
inode->i_generation = sbi->s_next_generation++;
@@ -950,6 +950,7 @@ fail_drop:
inode->i_flags |= S_NOQUOTA;
clear_nlink(inode);
unlock_new_inode(inode);
+fail_put:
iput(inode);
brelse(inode_bitmap_bh);
return ERR_PTR(err);
^ permalink raw reply related [flat|nested] 6+ messages in thread