* [PATCH] ext4: Report max_batch_time option correctly
@ 2012-01-02 14:13 Ben Hutchings
2012-01-03 15:46 ` Eric Sandeen
2012-01-05 2:23 ` Ted Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Ben Hutchings @ 2012-01-02 14:13 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger; +Cc: linux-ext4, Russell Coker, 654206
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Currently the value reported for max_batch_time is really the
value of min_batch_time.
Reported-by: Russell Coker <russell@coker.com.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 3e1329e..410e993 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1096,7 +1096,7 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
}
if (sbi->s_max_batch_time != EXT4_DEF_MAX_BATCH_TIME) {
seq_printf(seq, ",max_batch_time=%u",
- (unsigned) sbi->s_min_batch_time);
+ (unsigned) sbi->s_max_batch_time);
}
/*
--
1.7.7.3
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Report max_batch_time option correctly
2012-01-02 14:13 [PATCH] ext4: Report max_batch_time option correctly Ben Hutchings
@ 2012-01-03 15:46 ` Eric Sandeen
2012-01-05 2:23 ` Ted Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2012-01-03 15:46 UTC (permalink / raw)
To: Ben Hutchings
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, Russell Coker,
654206
On 1/2/12 8:13 AM, Ben Hutchings wrote:
> Currently the value reported for max_batch_time is really the
> value of min_batch_time.
>
> Reported-by: Russell Coker <russell@coker.com.au>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
whoops, yep!
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/ext4/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 3e1329e..410e993 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1096,7 +1096,7 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs)
> }
> if (sbi->s_max_batch_time != EXT4_DEF_MAX_BATCH_TIME) {
> seq_printf(seq, ",max_batch_time=%u",
> - (unsigned) sbi->s_min_batch_time);
> + (unsigned) sbi->s_max_batch_time);
> }
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Report max_batch_time option correctly
2012-01-02 14:13 [PATCH] ext4: Report max_batch_time option correctly Ben Hutchings
2012-01-03 15:46 ` Eric Sandeen
@ 2012-01-05 2:23 ` Ted Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Ted Ts'o @ 2012-01-05 2:23 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Andreas Dilger, linux-ext4, Russell Coker, 654206
On Mon, Jan 02, 2012 at 02:13:02PM +0000, Ben Hutchings wrote:
> Currently the value reported for max_batch_time is really the
> value of min_batch_time.
>
> Reported-by: Russell Coker <russell@coker.com.au>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 2:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-02 14:13 [PATCH] ext4: Report max_batch_time option correctly Ben Hutchings
2012-01-03 15:46 ` Eric Sandeen
2012-01-05 2:23 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).