From: Allison Henderson <achender@linux.vnet.ibm.com>
To: Hugh Dickins <hughd@google.com>
Cc: Dave Chinner <david@fromorbit.com>, linux-ext4@vger.kernel.org
Subject: Re: punch-hole should go beyond i_size
Date: Thu, 12 Jan 2012 20:18:11 -0700 [thread overview]
Message-ID: <4F0FA273.5060108@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1201121617320.1541@eggly.anvils>
On 01/12/2012 05:21 PM, Hugh Dickins wrote:
> On Thu, 12 Jan 2012, Allison Henderson wrote:
>> On 01/11/2012 07:55 PM, Dave Chinner wrote:
>>> On Wed, Jan 11, 2012 at 05:02:12PM -0800, Hugh Dickins wrote:
>>>>
>>>> ext4_ext_punch_hole() contains /* No need to punch hole beyond i_size */
>>>> early return, and trimming to i_size below, but forgets that the other
>>>> variety of fallocate(), with FALLOC_FL_KEEP_SIZE set, may have allocated
>>>> blocks beyond i_size. They can be removed with ftruncate(), but it is
>>>> unexpected for fallocate() not to undo its own work, and xfs does so.
>>>
>>> I'm pretty sure that's a bug as XFS allows punching holes in extents
>>> beyond EOF.
>>
>> Oh I see, I'll take a look at it, I think it will be ok to just take out the
>> early return. Thx!
>
> Thanks. And I've just noticed another, very easily fixed, error:
> I believe those -ENOTSUPPs in ext4_punch_hole() should be -EOPNOTSUPPs.
>
> Hugh
>
Ah, I think youre right, I will change the error values. I have the
current solution running in a test right now, and will post the patch
when it comes up clean. Thx!
Allison Henderson
next prev parent reply other threads:[~2012-01-13 3:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 1:02 punch-hole should go beyond i_size Hugh Dickins
2012-01-12 2:55 ` Dave Chinner
2012-01-12 16:23 ` Allison Henderson
2012-01-13 0:21 ` Hugh Dickins
2012-01-13 3:18 ` Allison Henderson [this message]
2012-05-13 21:13 ` Hugh Dickins
2012-05-15 21:36 ` Allison Henderson
2012-05-15 22:38 ` Hugh Dickins
2012-05-16 6:14 ` Lukáš Czerner
2012-05-16 18:09 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0FA273.5060108@linux.vnet.ibm.com \
--to=achender@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).