From: David Daney <david.daney@cavium.com>
To: Joe Perches <joe@perches.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] ext4: Add -DDEBUG to Makefile
Date: Fri, 16 Mar 2012 09:03:57 -0700 [thread overview]
Message-ID: <4F63646D.1040700@cavium.com> (raw)
In-Reply-To: <7ee60f3b750f4500f9bdcb64f358acbf17987036.1331856300.git.joe@perches.com>
On 03/15/2012 05:07 PM, Joe Perches wrote:
> Add -DDEBUG to enable future use of pr_debug.
> No changes to objects as no DEBUG uses currently exist.
>
> Signed-off-by: Joe Perches<joe@perches.com>
> ---
> fs/ext4/Makefile | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/Makefile b/fs/ext4/Makefile
> index 56fd8f86..617a5d8 100644
> --- a/fs/ext4/Makefile
> +++ b/fs/ext4/Makefile
> @@ -2,6 +2,8 @@
> # Makefile for the linux ext4-filesystem routines.
> #
>
> +ccflags-$(CONFIG_EXT4_FS) := -DDEBUG
In many other susbsystems/drivers, the definition of DEBUG is gated by a
separate Kconfig symbol used to select debugging just for that
susbsystem/driver (see CONFIG_MMC_DEBUG for example).
Why aren't you doing the same here?
David Daney
next prev parent reply other threads:[~2012-03-16 16:03 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 0:07 [PATCH 0/9] ext4: Message logging corrections and neatening Joe Perches
2012-03-16 0:07 ` [PATCH 1/9] ext4: Add -DDEBUG to Makefile Joe Perches
2012-03-16 16:03 ` David Daney [this message]
2012-03-16 16:29 ` Joe Perches
2012-03-19 4:39 ` Ted Ts'o
2012-03-19 16:26 ` Joe Perches
2012-03-19 18:48 ` David Daney
2012-03-20 1:05 ` Ted Ts'o
2012-03-16 0:07 ` [PATCH 2/9] ext4: Use pr_fmt and pr_<level> Joe Perches
2012-03-19 4:09 ` Ted Ts'o
2012-03-19 4:14 ` David Miller
2012-03-19 4:34 ` Ted Ts'o
2012-03-19 5:12 ` David Miller
2012-03-19 15:31 ` Ted Ts'o
2012-03-19 15:51 ` Anca Emanuel
2012-03-19 16:14 ` Joe Perches
2012-03-19 16:14 ` Ted Ts'o
2012-03-19 18:14 ` David Miller
2012-03-19 18:31 ` Ted Ts'o
2012-03-19 18:46 ` Joe Perches
2012-03-20 1:04 ` Ted Ts'o
2012-03-20 1:33 ` Joe Perches
2012-03-20 1:47 ` Ted Ts'o
2012-03-20 1:59 ` Joe Perches
2012-03-20 2:58 ` Ted Ts'o
2012-03-20 3:02 ` Joe Perches
2012-03-20 5:46 ` Valdis.Kletnieks
2012-03-20 7:10 ` David Miller
2012-03-20 8:47 ` Jiri Slaby
2012-03-20 9:44 ` Joe Perches
2012-03-20 9:27 ` Geert Uytterhoeven
2012-03-20 13:03 ` Ted Ts'o
2012-03-20 18:47 ` Valdis.Kletnieks
2012-03-20 1:46 ` Al Viro
2012-03-19 17:53 ` David Miller
2012-03-19 4:25 ` Joe Perches
2012-03-19 4:36 ` Ted Ts'o
2012-03-19 16:46 ` Jiri Slaby
2012-03-19 17:09 ` Joe Perches
2012-03-19 17:36 ` Valdis.Kletnieks
2012-03-19 17:44 ` Joe Perches
2012-03-20 1:06 ` Ted Ts'o
2012-03-20 1:28 ` david
2012-03-20 1:51 ` Joe Perches
2012-03-20 1:33 ` Joe Perches
2012-03-20 8:57 ` Jiri Slaby
2012-03-20 9:21 ` Joe Perches
2012-03-20 9:25 ` Jiri Slaby
2012-03-20 9:46 ` Joe Perches
2012-03-22 17:02 ` Jiri Slaby
2012-03-22 17:42 ` Joe Perches
2012-03-19 4:55 ` Ted Ts'o
2012-03-19 5:13 ` David Miller
2012-03-19 5:39 ` Joe Perches
2012-03-16 0:07 ` [PATCH 3/9] ext4: Fix indentation Joe Perches
2012-03-19 4:10 ` Ted Ts'o
2012-03-19 4:30 ` Joe Perches
2012-03-16 0:07 ` [PATCH 4/9] ext4: Add no_printk argument validation, fix fallout Joe Perches
2012-03-19 4:16 ` Ted Ts'o
2012-03-16 0:07 ` [PATCH 5/9] ext4: Avoid output message interleaving in ext4_error_<foo> Joe Perches
2012-03-19 4:51 ` Ted Ts'o
2012-03-16 0:07 ` [PATCH 6/9] ext4: Remove redundant "EXT4-fs: " from uses of ext4_msg Joe Perches
2012-03-19 4:13 ` Ted Ts'o
2012-03-16 0:07 ` [PATCH 7/9] ext4: Format neatening for easier grep Joe Perches
2012-03-19 4:26 ` Ted Ts'o
2012-03-19 4:30 ` Joe Perches
2012-03-16 0:07 ` [PATCH 8/9] ext4: Neaten ext4_error uses Joe Perches
2012-03-16 0:07 ` [PATCH 9/9] ext4: Rename ext4_warning to ext4_warn and ext4_error to ext4_err Joe Perches
2012-03-19 4:51 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F63646D.1040700@cavium.com \
--to=david.daney@cavium.com \
--cc=adilger.kernel@dilger.ca \
--cc=joe@perches.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).