[RFC PATCH 0/2] ext4: warn on and address allocation of unreserved meta blocks in ENOSPC conditions

[RFC PATCH 0/2] ext4: warn on and address allocation of unreserved meta blocks in ENOSPC conditions

[Brian Foster]

Hi,

This patch set addresses the following errors reproduced during xfstests 270 against an ext2 fs (loop) with delayed allocation enabled:

Mar 28 08:58:02 localhost kernel: [  171.526344] EXT4-fs (loop1): delayed block allocation failed for inode 14 at logical offset 64486 with max blocks 64 with error -28
Mar 28 08:58:02 localhost kernel: [  171.526346] EXT4-fs (loop1): This should not happen!! Data will be lost

270 ultimately fails with an inconsistent filesystem and requires an fsck to repair. The cause of the error is an underflow in ext4_da_update_reserve_space() due to an unreserved meta block allocation. I've split the fix into two technically independent changes and I'm sending this as an RFC because I'm relatively new to this code. Patch 1 adds a warning to detect the underflow condition and do an after the fact fix-up to prevent corruption. Patch 2 addresses the cause of this particular reservation failure. Further details are in the patch descriptions. 

I've run xfstests with these changes against ext2, ext3 and ext4. While I do reproduce a few other failures, these failures are also reproduced without these patches applied. Comments much appreciated.

Brian

[RFC PATCH 1/2] ext4: warn on delalloc md block allocation without reservation
[RFC PATCH 2/2] ext4: undo ei->i_da_metadata_calc_len increment if we fail to claim space