linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: linux-kernel@vger.kernel.org,
	"Jan Kara (maintainer:EXT2 FILE SYSTEM)" <jack@suse.cz>,
	"Andrew Morton (maintainer:EXT3 FILE SYSTEM)"
	<akpm@linux-foundation.org>,
	"Andreas Dilger (maintainer:EXT3 FILE SYSTEM)"
	<adilger.kernel@dilger.ca>,
	"\"Theodore Ts'o\" (maintainer:EXT4 FILE SYSTEM)" <tytso@mit.edu>,
	linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] implement uid and gid mount options for ext2, ext3 and ext4
Date: Wed, 25 Apr 2012 15:10:33 -0500	[thread overview]
Message-ID: <4F985A39.4060804@landley.net> (raw)
In-Reply-To: <4F97E5F2.50501@suse.de>

On 04/25/2012 06:54 AM, Ludwig Nussel wrote:
> Rob Landley wrote:
>> On 04/24/2012 10:29 AM, Ludwig Nussel wrote:
>>> Further development of a patch I sent years ago. I didn't find the
>>> time to address the concerns raised back then and forgot about the
>>> patch. Now here it is again.
>>
>> The doc bits look fine:
>>
>> Acked-by: Rob Landley <rob@landley.net>
>>
>> As for the design: why isn't this in the VFS instead of in ext234? It
>> seems like VFAT is more likely to need this, and I vaguely recall virtfs
>> (I.E. 9pfs) doing something similar...?
> 
> Yes, file systems like FAT that do not store ownership information
> themselves have a uid option. I agree that handling that in vfs itself
> would be the more generic solution. It would require more work though.

The right thing to do is often more work.  If it allows us to remove
existing duplicate code, even better...

Rob
-- 
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation.  Pick one.

  reply	other threads:[~2012-04-25 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24 15:29 [PATCH] implement uid and gid mount options for ext2, ext3 and ext4 Ludwig Nussel
     [not found] ` <4F971936.6070809@landley.net>
2012-04-25 11:54   ` Ludwig Nussel
2012-04-25 20:10     ` Rob Landley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-03  9:10 Ludwig Nussel
     [not found] ` <4FA2B0C1.4030206@landley.net>
2012-05-03 17:51   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F985A39.4060804@landley.net \
    --to=rob@landley.net \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludwig.nussel@suse.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).