* [PATCH] ext2: cleanup the comment for ext2_export_ops @ 2012-05-14 7:15 Wang Sheng-Hui 2012-05-14 9:55 ` Jan Kara 0 siblings, 1 reply; 4+ messages in thread From: Wang Sheng-Hui @ 2012-05-14 7:15 UTC (permalink / raw) To: Jan Kara, linux-ext4, linux-kernel ext2_export_ops gets more valued fields, not get_parent only. Clean up the comment. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- fs/ext2/super.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index e1025c7..640b4c6 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, /* Yes, most of these are left as NULL!! * A NULL value implies the default, which works with ext2-like file * systems, but can be improved upon. - * Currently only get_parent is required. */ static const struct export_operations ext2_export_ops = { .fh_to_dentry = ext2_fh_to_dentry, -- 1.7.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext2: cleanup the comment for ext2_export_ops 2012-05-14 7:15 [PATCH] ext2: cleanup the comment for ext2_export_ops Wang Sheng-Hui @ 2012-05-14 9:55 ` Jan Kara 2012-05-14 23:56 ` Wang Sheng-Hui 0 siblings, 1 reply; 4+ messages in thread From: Jan Kara @ 2012-05-14 9:55 UTC (permalink / raw) To: Wang Sheng-Hui; +Cc: Jan Kara, linux-ext4, linux-kernel On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote: > ext2_export_ops gets more valued fields, not get_parent only. > Clean up the comment. Um, I'd just remove the whole comment. It isn't particularly informative anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway... Honza > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > --- > fs/ext2/super.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index e1025c7..640b4c6 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, > /* Yes, most of these are left as NULL!! > * A NULL value implies the default, which works with ext2-like file > * systems, but can be improved upon. > - * Currently only get_parent is required. > */ > static const struct export_operations ext2_export_ops = { > .fh_to_dentry = ext2_fh_to_dentry, > -- > 1.7.1 -- Jan Kara <jack@suse.cz> SUSE Labs, CR ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext2: cleanup the comment for ext2_export_ops 2012-05-14 9:55 ` Jan Kara @ 2012-05-14 23:56 ` Wang Sheng-Hui 2012-05-15 9:59 ` Jan Kara 0 siblings, 1 reply; 4+ messages in thread From: Wang Sheng-Hui @ 2012-05-14 23:56 UTC (permalink / raw) To: Jan Kara; +Cc: linux-ext4, linux-kernel On 2012年05月14日 17:55, Jan Kara wrote: > On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote: >> ext2_export_ops gets more valued fields, not get_parent only. >> Clean up the comment. > Um, I'd just remove the whole comment. It isn't particularly informative > anyway - NULL meaning the default behavior is very common in kernel. And we > really set about half of entries anyway... > > Honza Thanks, Honza. Patch regenerated. Please check it. >> >> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> >> --- >> fs/ext2/super.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/fs/ext2/super.c b/fs/ext2/super.c >> index e1025c7..640b4c6 100644 >> --- a/fs/ext2/super.c >> +++ b/fs/ext2/super.c >> @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, >> /* Yes, most of these are left as NULL!! >> * A NULL value implies the default, which works with ext2-like file >> * systems, but can be improved upon. >> - * Currently only get_parent is required. >> */ >> static const struct export_operations ext2_export_ops = { >> .fh_to_dentry = ext2_fh_to_dentry, >> -- >> 1.7.1 From 362925f80bdfb1c105e346f535c5e51c7359b550 Mon Sep 17 00:00:00 2001 From: Wang Sheng-Hui <shhuiw@gmail.com> Date: Tue, 15 May 2012 07:53:46 +0800 Subject: [PATCH] ext2: remove the redundant comment for ext2_export_ops Per Honza, It isn't particularly informative anyway - NULL meaning the default behavior is very common in kernel. And we really set about half of entries anyway. Remove the whole comment for ext2_export_ops. Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- fs/ext2/super.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index e1025c7..f9b0f41 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -356,11 +356,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, ext2_nfs_get_inode); } -/* Yes, most of these are left as NULL!! - * A NULL value implies the default, which works with ext2-like file - * systems, but can be improved upon. - * Currently only get_parent is required. - */ static const struct export_operations ext2_export_ops = { .fh_to_dentry = ext2_fh_to_dentry, .fh_to_parent = ext2_fh_to_parent, -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext2: cleanup the comment for ext2_export_ops 2012-05-14 23:56 ` Wang Sheng-Hui @ 2012-05-15 9:59 ` Jan Kara 0 siblings, 0 replies; 4+ messages in thread From: Jan Kara @ 2012-05-15 9:59 UTC (permalink / raw) To: Wang Sheng-Hui; +Cc: Jan Kara, linux-ext4, linux-kernel On Tue 15-05-12 07:56:06, Wang Sheng-Hui wrote: > On 2012年05月14日 17:55, Jan Kara wrote: > > On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote: > >> ext2_export_ops gets more valued fields, not get_parent only. > >> Clean up the comment. > > Um, I'd just remove the whole comment. It isn't particularly informative > > anyway - NULL meaning the default behavior is very common in kernel. And we > > really set about half of entries anyway... > > > > Honza > > Thanks, Honza. > > Patch regenerated. Please check it. OK, thanks for the patch. Honza > >> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > >> --- > >> fs/ext2/super.c | 1 - > >> 1 files changed, 0 insertions(+), 1 deletions(-) > >> > >> diff --git a/fs/ext2/super.c b/fs/ext2/super.c > >> index e1025c7..640b4c6 100644 > >> --- a/fs/ext2/super.c > >> +++ b/fs/ext2/super.c > >> @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, > >> /* Yes, most of these are left as NULL!! > >> * A NULL value implies the default, which works with ext2-like file > >> * systems, but can be improved upon. > >> - * Currently only get_parent is required. > >> */ > >> static const struct export_operations ext2_export_ops = { > >> .fh_to_dentry = ext2_fh_to_dentry, > >> -- > >> 1.7.1 > > From 362925f80bdfb1c105e346f535c5e51c7359b550 Mon Sep 17 00:00:00 2001 > From: Wang Sheng-Hui <shhuiw@gmail.com> > Date: Tue, 15 May 2012 07:53:46 +0800 > Subject: [PATCH] ext2: remove the redundant comment for ext2_export_ops > > Per Honza, It isn't particularly informative anyway - NULL > meaning the default behavior is very common in kernel. And we > really set about half of entries anyway. > > Remove the whole comment for ext2_export_ops. > > Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> > --- > fs/ext2/super.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index e1025c7..f9b0f41 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -356,11 +356,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid, > ext2_nfs_get_inode); > } > > -/* Yes, most of these are left as NULL!! > - * A NULL value implies the default, which works with ext2-like file > - * systems, but can be improved upon. > - * Currently only get_parent is required. > - */ > static const struct export_operations ext2_export_ops = { > .fh_to_dentry = ext2_fh_to_dentry, > .fh_to_parent = ext2_fh_to_parent, > -- > 1.7.1 > -- Jan Kara <jack@suse.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-15 10:00 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-14 7:15 [PATCH] ext2: cleanup the comment for ext2_export_ops Wang Sheng-Hui 2012-05-14 9:55 ` Jan Kara 2012-05-14 23:56 ` Wang Sheng-Hui 2012-05-15 9:59 ` Jan Kara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).