From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Tao Ma <tm@tao.ma>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: let getattr report the right blocks in delalloc+bigalloc.
Date: Thu, 31 May 2012 22:52:33 -0500 [thread overview]
Message-ID: <4FC83C81.5090001@redhat.com> (raw)
In-Reply-To: <20120601004348.GB7897@thunk.org>
On 5/31/12 7:43 PM, Ted Ts'o wrote:
> On Thu, May 31, 2012 at 12:08:50PM -0500, Eric Sandeen wrote:
>> On 1/31/12 9:58 AM, Tao Ma wrote:
>>> From: Tao Ma <boyu.mt@taobao.com>
>>>
>>> In delayed allocation, i_reserved_data_blocks now indicates
>>> clusters, not blocks. So report it in the right number.
>>>
>>> This can be easily exposed by the following command:
>>> echo foo > blah; du -hc blah; sync; du -hc blah
>>>
>>> Cc: "Theodore Ts'o" <tytso@mit.edu>
>>> Reported-by: Eric Sandeen <sandeen@redhat.com>
>>> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
>>
>> Reviewed-by: Eric Sandeen <sandeen2redhat.com>
>>
>> It'd be great to get this one merged.
>
> I'll merge this, but delalloc and bigalloc is still pretty badly
> busted. But this will make stat return something that is closer to
> being correct...
Hm what else is busted? Is there a testcase written?
How much else do you know of that's busted with bigalloc? :)
(Is this bustedness the reason for not yet having it in the man page?)
-Eric
> - Ted
prev parent reply other threads:[~2012-06-01 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 15:58 [PATCH] ext4: let getattr report the right blocks in delalloc+bigalloc Tao Ma
2012-05-31 17:08 ` Eric Sandeen
2012-06-01 0:43 ` Ted Ts'o
2012-06-01 3:52 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC83C81.5090001@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).