linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Spelic <spelic@shiftmail.org>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
	Dave Chinner <david@fromorbit.com>, Spelic <spelic@shiftmail.org>,
	device-mapper development <dm-devel@redhat.com>,
	linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: Ext4 and xfs problems in dm-thin on allocation and discard
Date: Tue, 19 Jun 2012 13:29:55 +0200	[thread overview]
Message-ID: <4FE062B3.7080702@shiftmail.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1206190816440.2241@dhcp-1-248.brq.redhat.com>

On 06/19/12 08:32, Lukáš Czerner wrote:
>
> So do I understand correctly that even though the discard came
> through and thinp took advantage of it it still returns EOPNOTSUPP ?
> This seems rather suboptimal. IIRC there was a discussion to add an
> option to enable/disable sending discard in thinp target down
> to the device.

I'll ask this too...
do I understand correctly that dm-thin returns EOPNOTSUPP to the 
filesystem layer even though it is using the discard to unmap blocks, 
and at that point XFS stops sending discards down there (while ext4 
keeps sending them)?

This looks like a bug of dm-thin to me. Discards are "supported" in such 
a scenario.

Do you have a patch for dm-thin so to prevent it sending EOPTNOTSUPP ?

Thank you
S.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-06-19 11:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 21:33 Ext4 and xfs problems in dm-thin on allocation and discard Spelic
2012-06-19  1:57 ` Dave Chinner
2012-06-19  3:12   ` Mike Snitzer
2012-06-19  6:32     ` Lukáš Czerner
2012-06-19 11:29       ` Spelic [this message]
2012-06-19 12:20         ` Lukáš Czerner
2012-06-19 13:34         ` Mike Snitzer
2012-06-19 13:16       ` Mike Snitzer
2012-06-19 13:25         ` Lukáš Czerner
2012-06-19 13:30           ` Mike Snitzer
2012-06-19 13:52             ` Spelic
2012-06-19 14:05               ` Eric Sandeen
2012-06-19 14:44               ` Mike Snitzer
2012-06-19 18:48                 ` Mike Snitzer
2012-06-19 20:06                   ` Dave Chinner
2012-06-19 20:21                     ` Ted Ts'o
2012-06-19 20:39                       ` Dave Chinner
2012-06-20  9:01                         ` Christoph Hellwig
2012-06-19 21:37                     ` Spelic
2012-06-19 23:12                       ` Dave Chinner
2012-06-20 12:11   ` Spelic
2012-06-20 22:53     ` Dave Chinner
2012-06-21 17:47       ` Mike Snitzer
2012-06-21 23:29         ` Dave Chinner
2012-07-01 14:53         ` Paolo Bonzini
2012-07-02 13:00           ` Mike Snitzer
2012-07-02 13:15             ` Paolo Bonzini
2012-06-19 14:09 ` Lukáš Czerner
2012-06-19 14:19   ` Ted Ts'o
2012-06-19 14:23     ` Eric Sandeen
2012-06-19 14:37     ` Lukáš Czerner
2012-06-19 14:43     ` [dm-devel] " Alasdair G Kergon
2012-06-19 15:28       ` Mike Snitzer
2012-06-19 16:03         ` [dm-devel] " Alasdair G Kergon
2012-06-19 19:58         ` Ted Ts'o
2012-06-19 20:44           ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE062B3.7080702@shiftmail.org \
    --to=spelic@shiftmail.org \
    --cc=david@fromorbit.com \
    --cc=dm-devel@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).