From: Ric Wheeler <ricwheeler@gmail.com>
To: Fredrick <fjohnber@zoho.com>
Cc: Ric Wheeler <rwheeler@redhat.com>, Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>,
wenqing.lz@taobao.com, Eric Sandeen <sandeen@redhat.com>
Subject: Re: ext4_fallocate
Date: Tue, 26 Jun 2012 15:30:25 -0400 [thread overview]
Message-ID: <4FEA0DD1.8080403@gmail.com> (raw)
In-Reply-To: <4FE9F9F4.7010804@zoho.com>
On 06/26/2012 02:05 PM, Fredrick wrote:
>
>> Hi Ted,
>>
>> Has anyone made progress digging into the performance impact of running
>> without this patch? We should definitely see if there is some low
>> hanging fruit there, especially given that XFS does not seem to suffer
>> such a huge hit.
>>
>> I think that we need to get a good reproducer for the workload that
>> causes the pain and start to dig into this.
>>
>> Opening this security exposure is still something that is clearly a hack
>> and best avoided if we can fix the root cause :)
>>
>> Ric
>>
>>>
>
> Hi Ric,
>
> I had run perf stat on ext4 functions between two runs of our program
> writing data to a file for the first time and writing data to the file
> for the second time(where the extents are initialized).
> The amount of data written is same between the two runs.
>
> left is first time
> right is second time.
>
>
> < 42 ext4:ext4_mb_bitmap_load
> < 42 ext4:ext4_mb_buddy_bitmap_load
> < 642 ext4:ext4_mb_new_inode_pa
> < 645 ext4:ext4_mballoc_alloc
> < 9,596 ext4:ext4_mballoc_prealloc
> < 10,240 ext4:ext4_da_update_reserve_space
> ---
> > 7,413 ext4:ext4_mark_inode_dirty
> 49d52
> < 10,241 ext4:ext4_allocate_blocks
> 51d53
> < 10,241 ext4:ext4_request_blocks
> 55d56
> < 1,310,720 ext4:ext4_da_reserve_space
> 58,60c59,60
> < 1,331,288 ext4:ext4_ext_map_blocks_enter
> < 1,331,288 ext4:ext4_ext_map_blocks_exit
> < 1,341,467 ext4:ext4_mark_inode_dirty
> ---
> > 1,310,806 ext4:ext4_ext_map_blocks_enter
> > 1,310,806 ext4:ext4_ext_map_blocks_exit
>
>
> May be the mballocs have overhead.
>
> I ll try to compare numbers on XFS during this week.
>
> -Fredrick
>
Thanks! Eric is also running some tests to evaluate the impact of various
techniques :)
ric
next prev parent reply other threads:[~2012-06-26 19:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 6:42 ext4_fallocate Fredrick
2012-06-25 7:33 ` ext4_fallocate Andreas Dilger
2012-06-28 15:12 ` ext4_fallocate Phillip Susi
2012-06-28 15:23 ` ext4_fallocate Eric Sandeen
2012-06-25 8:51 ` ext4_fallocate Zheng Liu
2012-06-25 19:04 ` ext4_fallocate Fredrick
2012-06-25 19:17 ` ext4_fallocate Theodore Ts'o
2012-06-26 1:23 ` ext4_fallocate Fredrick
2012-06-26 13:13 ` ext4_fallocate Ric Wheeler
2012-06-26 17:30 ` ext4_fallocate Theodore Ts'o
2012-06-26 18:06 ` ext4_fallocate Fredrick
2012-06-26 18:21 ` ext4_fallocate Ric Wheeler
2012-06-26 18:57 ` ext4_fallocate Ted Ts'o
2012-06-26 19:22 ` ext4_fallocate Ric Wheeler
2012-06-26 18:05 ` ext4_fallocate Fredrick
2012-06-26 18:59 ` ext4_fallocate Ted Ts'o
2012-06-26 19:30 ` Ric Wheeler [this message]
2012-06-26 19:57 ` ext4_fallocate Eric Sandeen
2012-06-26 20:44 ` ext4_fallocate Eric Sandeen
2012-06-27 15:14 ` ext4_fallocate Eric Sandeen
2012-06-27 19:30 ` ext4_fallocate Theodore Ts'o
2012-06-27 23:02 ` ext4_fallocate Eric Sandeen
2012-06-28 11:27 ` ext4_fallocate Ric Wheeler
2012-06-29 19:02 ` ext4_fallocate Andreas Dilger
2012-07-02 3:03 ` ext4_fallocate Zheng Liu
2012-06-28 12:48 ` ext4_fallocate Theodore Ts'o
2012-07-02 3:16 ` ext4_fallocate Zheng Liu
2012-07-02 16:33 ` ext4_fallocate Eric Sandeen
2012-07-02 17:44 ` ext4_fallocate Jan Kara
2012-07-02 17:48 ` ext4_fallocate Ric Wheeler
2012-07-03 17:41 ` ext4_fallocate Zheng Liu
2012-07-03 17:57 ` ext4_fallocate Zach Brown
2012-07-04 2:23 ` ext4_fallocate Zheng Liu
2012-07-02 18:01 ` ext4_fallocate Theodore Ts'o
2012-07-03 9:30 ` ext4_fallocate Jan Kara
2012-07-04 1:15 ` ext4_fallocate Phillip Susi
2012-07-04 2:36 ` ext4_fallocate Zheng Liu
2012-07-04 3:06 ` ext4_fallocate Phillip Susi
2012-07-04 3:48 ` ext4_fallocate Zheng Liu
2012-07-04 12:20 ` ext4_fallocate Ric Wheeler
2012-07-04 13:25 ` ext4_fallocate Zheng Liu
2012-06-26 13:06 ` ext4_fallocate Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEA0DD1.8080403@gmail.com \
--to=ricwheeler@gmail.com \
--cc=adilger@dilger.ca \
--cc=fjohnber@zoho.com \
--cc=linux-ext4@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).