From: "Love, Robert W" <robert.w.love@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Scan Subscription <scan-subscription@coverity.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Chris Mason <chris.mason@fusionio.com>,
Bing Zhao <bzhao@marvell.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Theodore Ts'o <tytso@mit.edu>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
Mattia Dongili <malattia@linux.it>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: New Defects based on recent changes in Kernel code found by Coverity Scan
Date: Thu, 5 Jul 2012 15:12:21 +0000 [thread overview]
Message-ID: <4FF5AECA.40801@intel.com> (raw)
In-Reply-To: <20120703152739.ea7df9e6.akpm@linux-foundation.org>
On 7/3/2012 3:27 PM, Andrew Morton wrote:
> On Thu, 28 Jun 2012 11:32:09 -0700
> Scan Subscription <scan-subscription@coverity.com> wrote:
>
> ____________________________________________________________________________________________________________
> CID 703581 - NO_EFFECT Unsigned compared against 0 - This less-than-zero comparison of an unsigned value is never true. "*val < 0UL".
>
> drivers/scsi/fcoe/fcoe_sysfs.c:105
> 100 static int fcoe_str_to_dev_loss(const char *buf, unsigned long *val)
> 101 {
> 102 int ret;
> 103
> 104 ret = kstrtoul(buf, 0, val);
>>>>> CID 703581: Unsigned compared against 0 (NO_EFFECT) This less-than-zero comparison of an unsigned value is never true. "*val < 0UL".
>> 105 if (ret || *val < 0)
>> 106 return -EINVAL;
>> 107 /*
>> 108 * Check for overflow; dev_loss_tmo is u32
>>
Patch posted to linux-scsi.
Thanks, //Rob
next prev parent reply other threads:[~2012-07-05 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <829BE905228AE14A9AE1A46E6F2E371605538D039D@VA3DIAXVS891.RED001.local>
2012-07-03 22:27 ` New Defects based on recent changes in Kernel code found by Coverity Scan Andrew Morton
2012-07-03 23:05 ` Bing Zhao
2012-07-05 15:12 ` Love, Robert W [this message]
2012-07-05 15:33 ` Chris Mason
2012-07-05 19:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5AECA.40801@intel.com \
--to=robert.w.love@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.vasquez@qlogic.com \
--cc=bzhao@marvell.com \
--cc=chris.mason@fusionio.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=malattia@linux.it \
--cc=mjg@redhat.com \
--cc=scan-subscription@coverity.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).