From: Jeff Layton <jlayton@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: brauner@kernel.org, Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix decoding of raw_inode timestamps
Date: Wed, 12 Jul 2023 14:09:59 -0400 [thread overview]
Message-ID: <4c29c4e8f88509b2f8e8c08197dba8cfeb07c045.camel@kernel.org> (raw)
In-Reply-To: <20230712175258.GB3677745@mit.edu>
On Wed, 2023-07-12 at 13:52 -0400, Theodore Ts'o wrote:
> On Wed, Jul 12, 2023 at 11:02:49AM -0400, Jeff Layton wrote:
> > When we covert a timestamp from raw disk format, we need to consider it
> > to be signed, as the value may represent a date earlier than 1970. This
> > fixes generic/258 on ext4.
> >
> > Cc: Jan Kara <jack@suse.cz>
> > Fixes: f2ddb05870fb ("ext4: convert to ctime accessor functions")
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>
> Acked-by: Theodore Ts'o <tytso@mit.edu>
>
> Thanks for the fix!
>
> It had been on my list to checking to see if the ext4 kunit tests
> would pass, since Jan had mentioned that he had done the work to make
> sure the ext4 kunit test would compile, but he hadn't gotten around to
> try run the kunit test. Unfortunately, I hadn't gotten to it.
>
> I *think* the ext4 kunit tests should have caught this as well; out of
> curiosity, have you tried running the ext4 kunit tests either before
> or after this patch? If so, what were your findings?
>
> Cheers,
>
> - Ted
No, I haven't. I'm running fstests on it now. Is there a quickstart for
running those tests?
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-07-12 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 15:02 [PATCH] ext4: fix decoding of raw_inode timestamps Jeff Layton
2023-07-12 15:32 ` Christian Brauner
2023-07-12 17:52 ` Theodore Ts'o
2023-07-12 18:09 ` Jeff Layton [this message]
2023-07-12 21:25 ` Theodore Ts'o
2023-07-13 10:48 ` Jeff Layton
2023-07-13 13:04 ` Theodore Ts'o
2023-07-13 13:19 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c29c4e8f88509b2f8e8c08197dba8cfeb07c045.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox