linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][v2] ext4: change a comment on fs/ext4/extents.c
@ 2012-06-21 13:23 haiboliu6
  2012-07-09 14:21 ` [v2] " Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: haiboliu6 @ 2012-06-21 13:23 UTC (permalink / raw)
  To: linux-ext4; +Cc: HaiboLiu

From: HaiboLiu <HaiboLiu6@gmail.com>

In this patch, ext4_ext_try_to_merge has been change to merge 
an extent both left and right. So we need to update the comment
in here.

v1->v2: update the subject and the patch comment.

Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>
---
 fs/ext4/extents.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 74f23c2..db671b9 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1807,11 +1807,10 @@ has_space:
 	nearex->ee_len = newext->ee_len;
 
 merge:
-	/* try to merge extents to the right */
+	/* try to merge extents */
 	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
 		ext4_ext_try_to_merge(inode, path, nearex);
 
-	/* try to merge extents to the left */
 
 	/* time to correct all indexes above */
 	err = ext4_ext_correct_indexes(handle, inode, path);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [v2] ext4: change a comment on fs/ext4/extents.c
  2012-06-21 13:23 [PATCH][v2] ext4: change a comment on fs/ext4/extents.c haiboliu6
@ 2012-07-09 14:21 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2012-07-09 14:21 UTC (permalink / raw)
  To: Liu Haibo; +Cc: linux-ext4

On Thu, Jun 21, 2012 at 03:23:14AM -0000, Liu Haibo wrote:
> From: HaiboLiu <HaiboLiu6@gmail.com>
> 
> In this patch, ext4_ext_try_to_merge has been change to merge 
> an extent both left and right. So we need to update the comment
> in here.
> 
> v1->v2: update the subject and the patch comment.
> 
> Signed-off-by: HaiboLiu <HaiboLiu6@gmail.com>

Applied, thanks.

BTW, in the future, it's better to put the v1-v2 log after the "---"
separator.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-09 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 13:23 [PATCH][v2] ext4: change a comment on fs/ext4/extents.c haiboliu6
2012-07-09 14:21 ` [v2] " Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).