From: Brian Foster <bfoster@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: Eric Sandeen <esandeen@redhat.com>, Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH] ext4: do not enable delalloc by default for ext2
Date: Fri, 13 Jul 2012 10:23:22 -0400 [thread overview]
Message-ID: <50002F5A.90908@redhat.com> (raw)
In-Reply-To: <4F71C4B3.9090402@redhat.com>
On 03/27/2012 09:46 AM, Brian Foster wrote:
> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> fs/ext4/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9339009..b08a547 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> * enable delayed allocation by default
> * Use -o nodelalloc to turn it off
> */
> - if (!IS_EXT3_SB(sb) &&
> + if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
> ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
> set_opt(sb, DELALLOC);
>
>
Ping... Any comments on this? Thanks.
Brian
next prev parent reply other threads:[~2012-07-13 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:46 [PATCH] ext4: do not enable delalloc by default for ext2 Brian Foster
2012-03-27 15:34 ` Eric Sandeen
2012-07-13 14:23 ` Brian Foster [this message]
2012-09-11 16:07 ` Eric Sandeen
2012-09-18 2:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50002F5A.90908@redhat.com \
--to=bfoster@redhat.com \
--cc=esandeen@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).