[PATCH] ext4: do not enable delalloc by default for ext2

[PATCH] ext4: do not enable delalloc by default for ext2

[Brian Foster]

Use traditional ext2 mount options. Do not enable delalloc by default for ext2.

Signed-off-by: Brian Foster <bfoster@redhat.com>
---
 fs/ext4/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9339009..b08a547 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 	 * enable delayed allocation by default
 	 * Use -o nodelalloc to turn it off
 	 */
-	if (!IS_EXT3_SB(sb) &&
+	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
 	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
 		set_opt(sb, DELALLOC);
 
-- 
1.7.7.6

Re: [PATCH] ext4: do not enable delalloc by default for ext2

[Eric Sandeen]

On 3/27/12 8:46 AM, Brian Foster wrote:
> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.

This makes sense to me, I think.

It was done for ext3 to semi-preserve the journal "5s sync" I think, and
one could argue that delalloc is ok for ext2, but it seems like people would
expect behavior which is as close to what ext2.ko provided as possible.  So,

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
>  fs/ext4/super.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9339009..b08a547 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  	 * enable delayed allocation by default
>  	 * Use -o nodelalloc to turn it off
>  	 */
> -	if (!IS_EXT3_SB(sb) &&
> +	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
>  	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
>  		set_opt(sb, DELALLOC);
>  

Re: [PATCH] ext4: do not enable delalloc by default for ext2

[Brian Foster]

On 03/27/2012 09:46 AM, Brian Foster wrote:
> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.
> 
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
>  fs/ext4/super.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9339009..b08a547 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  	 * enable delayed allocation by default
>  	 * Use -o nodelalloc to turn it off
>  	 */
> -	if (!IS_EXT3_SB(sb) &&
> +	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
>  	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
>  		set_opt(sb, DELALLOC);
>  
> 

Ping... Any comments on this? Thanks.

Brian

Re: [PATCH] ext4: do not enable delalloc by default for ext2

[Eric Sandeen]

On 7/13/12 9:23 AM, Brian Foster wrote:
> On 03/27/2012 09:46 AM, Brian Foster wrote:
>> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.
>>
>> Signed-off-by: Brian Foster <bfoster@redhat.com>
>> ---
>>  fs/ext4/super.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 9339009..b08a547 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>>  	 * enable delayed allocation by default
>>  	 * Use -o nodelalloc to turn it off
>>  	 */
>> -	if (!IS_EXT3_SB(sb) &&
>> +	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
>>  	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
>>  		set_opt(sb, DELALLOC);
>>  
>>
> 
> Ping... Any comments on this? Thanks.

Ping again?

Ted, this has my reviewed-by, I think it really makes sense to push in to keep ext2 behavior close to the same as it was in ext2.ko.

Thanks,
-Eric

> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] ext4: do not enable delalloc by default for ext2

[Theodore Ts'o]

On Tue, Mar 27, 2012 at 09:46:27AM -0400, Brian Foster wrote:
> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.
> 
> Signed-off-by: Brian Foster <bfoster@redhat.com>

Thanks, applied.

						- Ted