From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F87ECAAA1 for ; Mon, 12 Sep 2022 02:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbiILCUc (ORCPT ); Sun, 11 Sep 2022 22:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbiILCUb (ORCPT ); Sun, 11 Sep 2022 22:20:31 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72531DA41 for ; Sun, 11 Sep 2022 19:20:29 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MQqvZ0yy5zNm6Y; Mon, 12 Sep 2022 10:15:54 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 10:20:27 +0800 Subject: Re: [PATCH v2 03/13] ext4: factor out ext4_set_def_opts() To: "Ritesh Harjani (IBM)" CC: , , , , References: <20220903030156.770313-1-yanaijie@huawei.com> <20220903030156.770313-4-yanaijie@huawei.com> <20220908084426.w4ltd7cotudoykyw@riteshh-domain> From: Jason Yan Message-ID: <5000fb7d-21ce-ed5c-a621-6f91dec527e0@huawei.com> Date: Mon, 12 Sep 2022 10:20:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20220908084426.w4ltd7cotudoykyw@riteshh-domain> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi Ritesh, thanks for the review. On 2022/9/8 16:44, Ritesh Harjani (IBM) wrote: > On 22/09/03 11:01AM, Jason Yan wrote: >> Factor out ext4_set_def_opts(). No functional change. > if (blocksize == PAGE_SIZE) > set_opt(sb, DIOREAD_NOLOCK); > The patch looks good however, even this ^^ could be moved in > ext4_set_def_opts() via some refactoring. > > If required you could even submit a seperate change for above. > Yes, this needs some refactoring. I would like to make a separate patch in my next series. Jason > Otherwise this change looks good to me. > Reviewed-by: Ritesh Harjani (IBM) > >