* [PATCH] ext4: get rid of the duplicate code on ext4_fill_super
@ 2012-10-29 7:32 Zhao Hongjiang
2012-11-08 17:14 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Zhao Hongjiang @ 2012-10-29 7:32 UTC (permalink / raw)
To: tytso; +Cc: adilger.kernel, linux-ext4, linux-kernel
From: Zhao Hongjiang <zhaohongjiang@huawei.com>
Clean the duplicate code on ext4_fill_super cause the bellow
also have it.
Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
---
fs/ext4/super.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 80928f7..d21b985 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3272,9 +3272,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
}
sb->s_fs_info = sbi;
sbi->s_sb = sb;
- sbi->s_mount_opt = 0;
- sbi->s_resuid = make_kuid(&init_user_ns, EXT4_DEF_RESUID);
- sbi->s_resgid = make_kgid(&init_user_ns, EXT4_DEF_RESGID);
sbi->s_inode_readahead_blks = EXT4_DEF_INODE_READAHEAD_BLKS;
sbi->s_sb_block = sb_block;
if (sb->s_bdev->bd_part)
-- 1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: get rid of the duplicate code on ext4_fill_super
2012-10-29 7:32 [PATCH] ext4: get rid of the duplicate code on ext4_fill_super Zhao Hongjiang
@ 2012-11-08 17:14 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2012-11-08 17:14 UTC (permalink / raw)
To: Zhao Hongjiang; +Cc: adilger.kernel, linux-ext4, linux-kernel
On Mon, Oct 29, 2012 at 03:32:08PM +0800, Zhao Hongjiang wrote:
> From: Zhao Hongjiang <zhaohongjiang@huawei.com>
>
> Clean the duplicate code on ext4_fill_super cause the bellow
> also have it.
>
> Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Applied, thanks!
I used the commit description:
ext4: get rid of redundant code in ext4_fill_super()
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-08 22:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-29 7:32 [PATCH] ext4: get rid of the duplicate code on ext4_fill_super Zhao Hongjiang
2012-11-08 17:14 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).