From: Rich Johnston <rjohnston@sgi.com>
To: <xfs@oss.sgi.com>, Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: xfstests: test ext4 statfs
Date: Mon, 29 Oct 2012 09:12:26 -0500 [thread overview]
Message-ID: <508E8ECA.2080204@sgi.com> (raw)
In-Reply-To: <508E8480.5020507@sgi.com>
xfstests: test ext4 statfs
Calculating free blocks in ext[234] is surprisingly hard, since
by default we report "bsd" style df which doesn't count filesystem
"overhead" blocks as used.
With a lot of code dedicated to sorting out what to report as
free, things tend to go wrong surprisingly often.
Here's a test to actually try to stop the next regression. ;)
NB: For bsddf, the kernel currently does not count journal blocks
as overhead; it probably should. But the test below looks to have
the result within 1% of perfection, so it still passes even if
the kernel doesn't count the journal against free blocks.
Eric,
This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests,
master branch, commit 0b2ab695.
Thanks
--Rich
prev parent reply other threads:[~2012-10-29 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 17:19 [PATCH] xfstests: test ext4 statfs Eric Sandeen
2012-10-26 18:03 ` Rich Johnston
2012-10-26 18:39 ` Eric Sandeen
2012-10-29 13:28 ` Rich Johnston
2012-10-29 14:12 ` Rich Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E8ECA.2080204@sgi.com \
--to=rjohnston@sgi.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).