From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: [PATCH] ext4: remove unaligned AIO warning printk
Date: Wed, 21 Nov 2012 11:05:52 -0600 [thread overview]
Message-ID: <50AD09F0.6090706@redhat.com> (raw)
Although I put this in, I now think it was a bad decision.
For most users, there is very little to be done in this case. They
get the message, once per day, with no real context or proposed action.
TBH, it generates support calls when it probably does not need to;
the message sounds more dire than the situation really is.
Just nuke it. Normal investigation via blktrace or whatnot can
reveal poor IO patterns if bad performance is encountered.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index bf3966b..6c6b741 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -107,14 +107,6 @@ ext4_file_dio_write(struct kiocb *iocb, const struct iovec *iov,
/* Unaligned direct AIO must be serialized; see comment above */
if (unaligned_aio) {
- static unsigned long unaligned_warn_time;
next reply other threads:[~2012-11-21 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 17:05 Eric Sandeen [this message]
2012-11-21 19:47 ` [PATCH] ext4: remove unaligned AIO warning printk Theodore Ts'o
2012-11-21 20:03 ` Eric Sandeen
2012-12-25 18:34 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AD09F0.6090706@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).