* How to run xfstests against multipath disks on SuSE? @ 2012-11-26 0:00 Ryan Wang 2012-11-26 13:43 ` Lukáš Czerner 0 siblings, 1 reply; 9+ messages in thread From: Ryan Wang @ 2012-11-26 0:00 UTC (permalink / raw) To: linux-ext4, Theodore Ts'o Hello, I tried to kick off xfstests on multipath device, e.g I set TEST_DEV="/dev/mapper/mpatha", which is a symlink to "/dev/dm-0". I run mkfs on mpatha beforehand. When I run "./check 001", it said: " common.rc: Error: $TEST_DEV (/dev/dm-0) is not a MOUNTED ext4 filesystem " The I checked the script common.rc, and found that it uses df to determine the filesystem type and it uses the realpath "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always shows "devtmpfs" instead of "ext4" for /dev/dm-0. I run "mount" and found that devtmpfs is mount on /dev/ on opensuse ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", df still showed devtmpfs. Any ideas to kick off the xfstests? thanks, ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-26 0:00 How to run xfstests against multipath disks on SuSE? Ryan Wang @ 2012-11-26 13:43 ` Lukáš Czerner 2012-11-26 14:55 ` Theodore Ts'o 0 siblings, 1 reply; 9+ messages in thread From: Lukáš Czerner @ 2012-11-26 13:43 UTC (permalink / raw) To: Ryan Wang; +Cc: linux-ext4, Theodore Ts'o, xfs On Mon, 26 Nov 2012, Ryan Wang wrote: > Date: Mon, 26 Nov 2012 08:00:05 +0800 > From: Ryan Wang <openspace.wang@gmail.com> > To: linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu> > Subject: How to run xfstests against multipath disks on SuSE? Maybe cc xfstests developers as well ? xfs@oss.sgi.com added to cc. > > Hello, > > I tried to kick off xfstests on multipath device, e.g I set > TEST_DEV="/dev/mapper/mpatha", which is a symlink > to "/dev/dm-0". I run mkfs on mpatha beforehand. > > When I run "./check 001", it said: > " > common.rc: Error: $TEST_DEV (/dev/dm-0) is not a MOUNTED ext4 filesystem > " > > The I checked the script common.rc, and found that it uses > df to determine the filesystem type and it uses the realpath > "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always > shows "devtmpfs" instead of "ext4" for /dev/dm-0. > > I run "mount" and found that devtmpfs is mount on /dev/ on opensuse > ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", > df still showed devtmpfs. > > Any ideas to kick off the xfstests? > > thanks, > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-26 13:43 ` Lukáš Czerner @ 2012-11-26 14:55 ` Theodore Ts'o 2012-11-27 1:20 ` Ryan Wang 0 siblings, 1 reply; 9+ messages in thread From: Theodore Ts'o @ 2012-11-26 14:55 UTC (permalink / raw) To: Lukáš Czerner; +Cc: Ryan Wang, linux-ext4, xfs On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: > > The I checked the script common.rc, and found that it uses > > df to determine the filesystem type and it uses the realpath > > "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always > > shows "devtmpfs" instead of "ext4" for /dev/dm-0. > > > > I run "mount" and found that devtmpfs is mount on /dev/ on opensuse > > ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", > > df still showed devtmpfs. > > > > Any ideas to kick off the xfstests? At least with the df which ships with Debian Testing, df will display the file system in use if it matches the device name which is /etc/mtab. It looks the issue is that mount is canonicalizing the device name to be the human friendly version: # ls -l /dev/mapper/closure-bigscratch 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 <tytso.root@closure> {/home/tytso/bin}, level 2 # mount /dev/dm-7 /u2 # df /u2 Filesystem 1K-blocks Used Available Use% Mounted on /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 # grep /u2 /etc/mtab /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 So the simplest solution is to just use /dev/mapper/mpatha instead of insisting on using /dev/dm-0. That's what I do.... - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-26 14:55 ` Theodore Ts'o @ 2012-11-27 1:20 ` Ryan Wang 2012-11-27 3:14 ` Dave Chinner 0 siblings, 1 reply; 9+ messages in thread From: Ryan Wang @ 2012-11-27 1:20 UTC (permalink / raw) To: Theodore Ts'o; +Cc: Lukáš Czerner, linux-ext4, xfs 2012/11/26 Theodore Ts'o <tytso@mit.edu>: > On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: >> > The I checked the script common.rc, and found that it uses >> > df to determine the filesystem type and it uses the realpath >> > "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always >> > shows "devtmpfs" instead of "ext4" for /dev/dm-0. >> > >> > I run "mount" and found that devtmpfs is mount on /dev/ on opensuse >> > ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", >> > df still showed devtmpfs. >> > >> > Any ideas to kick off the xfstests? > > At least with the df which ships with Debian Testing, df will display > the file system in use if it matches the device name which is > /etc/mtab. It looks the issue is that mount is canonicalizing the > device name to be the human friendly version: > > # ls -l /dev/mapper/closure-bigscratch > 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 > <tytso.root@closure> {/home/tytso/bin}, level 2 > # mount /dev/dm-7 /u2 > # df /u2 > Filesystem 1K-blocks Used Available Use% Mounted on > /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 > # grep /u2 /etc/mtab > /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 > > So the simplest solution is to just use /dev/mapper/mpatha instead of > insisting on using /dev/dm-0. That's what I do.... In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, even if you specified /dev/mapper/mpatha. My problem is in SuSE, the devtmpfs is mounted on /dev by default, seems used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext4. > > - Ted > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-27 1:20 ` Ryan Wang @ 2012-11-27 3:14 ` Dave Chinner 2012-11-27 17:08 ` Eric Sandeen 0 siblings, 1 reply; 9+ messages in thread From: Dave Chinner @ 2012-11-27 3:14 UTC (permalink / raw) To: Ryan Wang; +Cc: Theodore Ts'o, Lukáš Czerner, linux-ext4, xfs On Tue, Nov 27, 2012 at 09:20:47AM +0800, Ryan Wang wrote: > 2012/11/26 Theodore Ts'o <tytso@mit.edu>: > > On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: > >> > The I checked the script common.rc, and found that it uses > >> > df to determine the filesystem type and it uses the realpath > >> > "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always > >> > shows "devtmpfs" instead of "ext4" for /dev/dm-0. > >> > > >> > I run "mount" and found that devtmpfs is mount on /dev/ on opensuse > >> > ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", > >> > df still showed devtmpfs. > >> > > >> > Any ideas to kick off the xfstests? > > > > At least with the df which ships with Debian Testing, df will display > > the file system in use if it matches the device name which is > > /etc/mtab. It looks the issue is that mount is canonicalizing the > > device name to be the human friendly version: > > > > # ls -l /dev/mapper/closure-bigscratch > > 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 > > <tytso.root@closure> {/home/tytso/bin}, level 2 > > # mount /dev/dm-7 /u2 > > # df /u2 > > Filesystem 1K-blocks Used Available Use% Mounted on > > /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 > > # grep /u2 /etc/mtab > > /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 > > > > So the simplest solution is to just use /dev/mapper/mpatha instead of > > insisting on using /dev/dm-0. That's what I do.... > > In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, even if you > specified /dev/mapper/mpatha. > My problem is in SuSE, the devtmpfs is mounted on /dev by default, seems > used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext4. What version of xfstests are you using? Do you have a "README.device-mapper" file in the base directory? If not, upgrade to the latest version and retry. $ gl -n 1 -p 0a81886 commit 0a818862bb74932e15971ec8bedb55765ec3a3f6 Author: Christoph Hellwig <hch@lst.de> Date: Wed May 4 16:28:32 2011 +0200 xfstests: support post-udev device mapper nodes Because of udevs complaining device mapper now creates /dev/dm-N as the real device nodes, and just symlinks the /dev/mapper/ names to it. This would be easy if everything used the /dev/mapper clear names, but most system utilities translate them back to the /dev/mapper/ names and thus confuse various test cases. Add support to _is_block_dev to read symlinks, and add documentation on how to run xfstests on device mapper volumes. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Alex Elder <aelder@sgi.com> Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-27 3:14 ` Dave Chinner @ 2012-11-27 17:08 ` Eric Sandeen 2012-11-27 20:35 ` Dave Chinner 0 siblings, 1 reply; 9+ messages in thread From: Eric Sandeen @ 2012-11-27 17:08 UTC (permalink / raw) To: Dave Chinner Cc: Ryan Wang, Theodore Ts'o, Lukáš Czerner, linux-ext4, xfs On 11/26/12 9:14 PM, Dave Chinner wrote: > On Tue, Nov 27, 2012 at 09:20:47AM +0800, Ryan Wang wrote: >> 2012/11/26 Theodore Ts'o <tytso@mit.edu>: >>> On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: >>>>> The I checked the script common.rc, and found that it uses >>>>> df to determine the filesystem type and it uses the realpath >>>>> "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always >>>>> shows "devtmpfs" instead of "ext4" for /dev/dm-0. >>>>> >>>>> I run "mount" and found that devtmpfs is mount on /dev/ on opensuse >>>>> ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", >>>>> df still showed devtmpfs. >>>>> >>>>> Any ideas to kick off the xfstests? >>> >>> At least with the df which ships with Debian Testing, df will display >>> the file system in use if it matches the device name which is >>> /etc/mtab. It looks the issue is that mount is canonicalizing the >>> device name to be the human friendly version: >>> >>> # ls -l /dev/mapper/closure-bigscratch >>> 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 >>> <tytso.root@closure> {/home/tytso/bin}, level 2 >>> # mount /dev/dm-7 /u2 >>> # df /u2 >>> Filesystem 1K-blocks Used Available Use% Mounted on >>> /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 >>> # grep /u2 /etc/mtab >>> /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 >>> >>> So the simplest solution is to just use /dev/mapper/mpatha instead of >>> insisting on using /dev/dm-0. That's what I do.... >> >> In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, even if you >> specified /dev/mapper/mpatha. >> My problem is in SuSE, the devtmpfs is mounted on /dev by default, seems >> used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext4. > > What version of xfstests are you using? Do you have a > "README.device-mapper" file in the base directory? If not, upgrade > to the latest version and retry. > > $ gl -n 1 -p 0a81886 > commit 0a818862bb74932e15971ec8bedb55765ec3a3f6 > Author: Christoph Hellwig <hch@lst.de> > Date: Wed May 4 16:28:32 2011 +0200 > > xfstests: support post-udev device mapper nodes > > Because of udevs complaining device mapper now creates /dev/dm-N as the real > device nodes, and just symlinks the /dev/mapper/ names to it. This would be > easy if everything used the /dev/mapper clear names, but most system utilities > translate them back to the /dev/mapper/ names and thus confuse various test > cases. Add support to _is_block_dev to read symlinks, and add documentation > on how to run xfstests on device mapper volumes. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Alex Elder <aelder@sgi.com> > > Cheers, > > Dave. > Recent "realpath" changes also went in: b03c662399956609934ff063e9064e15dc7459ac xfstests: fix to build src/realpath and the correct the existence of target devices d5ea873fcbf00b841f0511a26fb341364a5c6425 xfstests: resolve symlinked devices to real paths so either of those could have broken and/or fixed it for you :) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-27 17:08 ` Eric Sandeen @ 2012-11-27 20:35 ` Dave Chinner 2012-11-27 20:37 ` Eric Sandeen 0 siblings, 1 reply; 9+ messages in thread From: Dave Chinner @ 2012-11-27 20:35 UTC (permalink / raw) To: Eric Sandeen Cc: Ryan Wang, Theodore Ts'o, Lukáš Czerner, linux-ext4, xfs On Tue, Nov 27, 2012 at 11:08:30AM -0600, Eric Sandeen wrote: > On 11/26/12 9:14 PM, Dave Chinner wrote: > > On Tue, Nov 27, 2012 at 09:20:47AM +0800, Ryan Wang wrote: > >> 2012/11/26 Theodore Ts'o <tytso@mit.edu>: > >>> On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: > >>>>> The I checked the script common.rc, and found that it uses > >>>>> df to determine the filesystem type and it uses the realpath > >>>>> "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always > >>>>> shows "devtmpfs" instead of "ext4" for /dev/dm-0. > >>>>> > >>>>> I run "mount" and found that devtmpfs is mount on /dev/ on opensuse > >>>>> ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", > >>>>> df still showed devtmpfs. > >>>>> > >>>>> Any ideas to kick off the xfstests? > >>> > >>> At least with the df which ships with Debian Testing, df will display > >>> the file system in use if it matches the device name which is > >>> /etc/mtab. It looks the issue is that mount is canonicalizing the > >>> device name to be the human friendly version: > >>> > >>> # ls -l /dev/mapper/closure-bigscratch > >>> 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 > >>> <tytso.root@closure> {/home/tytso/bin}, level 2 > >>> # mount /dev/dm-7 /u2 > >>> # df /u2 > >>> Filesystem 1K-blocks Used Available Use% Mounted on > >>> /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 > >>> # grep /u2 /etc/mtab > >>> /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 > >>> > >>> So the simplest solution is to just use /dev/mapper/mpatha instead of > >>> insisting on using /dev/dm-0. That's what I do.... > >> > >> In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, even if you > >> specified /dev/mapper/mpatha. > >> My problem is in SuSE, the devtmpfs is mounted on /dev by default, seems > >> used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext4. > > > > What version of xfstests are you using? Do you have a > > "README.device-mapper" file in the base directory? If not, upgrade > > to the latest version and retry. > > > > $ gl -n 1 -p 0a81886 > > commit 0a818862bb74932e15971ec8bedb55765ec3a3f6 > > Author: Christoph Hellwig <hch@lst.de> > > Date: Wed May 4 16:28:32 2011 +0200 > > > > xfstests: support post-udev device mapper nodes > > > > Because of udevs complaining device mapper now creates /dev/dm-N as the real > > device nodes, and just symlinks the /dev/mapper/ names to it. This would be > > easy if everything used the /dev/mapper clear names, but most system utilities > > translate them back to the /dev/mapper/ names and thus confuse various test > > cases. Add support to _is_block_dev to read symlinks, and add documentation > > on how to run xfstests on device mapper volumes. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Alex Elder <aelder@sgi.com> > > > > Cheers, > > > > Dave. > > > > Recent "realpath" changes also went in: > > b03c662399956609934ff063e9064e15dc7459ac xfstests: fix to build src/realpath and the correct the existence of target devices > d5ea873fcbf00b841f0511a26fb341364a5c6425 xfstests: resolve symlinked devices to real paths > > so either of those could have broken and/or fixed it for you :) Yup, those are almost certainly the patches that broke device mapper support. There' aren't changes to common.rc, so I didn't notice them. They basically override the fix that Christoph made to support /dev/mapper links properly. I'd suggest a revert is in order, the two patches above were part of Rich's hovering of old, unreviewed patches. This problem was already fixed in a different way by Christoph, so adding these patches was wrong. Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-27 20:35 ` Dave Chinner @ 2012-11-27 20:37 ` Eric Sandeen 2012-11-27 20:55 ` Rich Johnston 0 siblings, 1 reply; 9+ messages in thread From: Eric Sandeen @ 2012-11-27 20:37 UTC (permalink / raw) To: Dave Chinner Cc: Ryan Wang, Theodore Ts'o, Lukáš Czerner, linux-ext4, xfs On 11/27/12 2:35 PM, Dave Chinner wrote: > On Tue, Nov 27, 2012 at 11:08:30AM -0600, Eric Sandeen wrote: >> On 11/26/12 9:14 PM, Dave Chinner wrote: >>> On Tue, Nov 27, 2012 at 09:20:47AM +0800, Ryan Wang wrote: >>>> 2012/11/26 Theodore Ts'o <tytso@mit.edu>: >>>>> On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: >>>>>>> The I checked the script common.rc, and found that it uses >>>>>>> df to determine the filesystem type and it uses the realpath >>>>>>> "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always >>>>>>> shows "devtmpfs" instead of "ext4" for /dev/dm-0. >>>>>>> >>>>>>> I run "mount" and found that devtmpfs is mount on /dev/ on opensuse >>>>>>> ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", >>>>>>> df still showed devtmpfs. >>>>>>> >>>>>>> Any ideas to kick off the xfstests? >>>>> >>>>> At least with the df which ships with Debian Testing, df will display >>>>> the file system in use if it matches the device name which is >>>>> /etc/mtab. It looks the issue is that mount is canonicalizing the >>>>> device name to be the human friendly version: >>>>> >>>>> # ls -l /dev/mapper/closure-bigscratch >>>>> 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 >>>>> <tytso.root@closure> {/home/tytso/bin}, level 2 >>>>> # mount /dev/dm-7 /u2 >>>>> # df /u2 >>>>> Filesystem 1K-blocks Used Available Use% Mounted on >>>>> /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 >>>>> # grep /u2 /etc/mtab >>>>> /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 >>>>> >>>>> So the simplest solution is to just use /dev/mapper/mpatha instead of >>>>> insisting on using /dev/dm-0. That's what I do.... >>>> >>>> In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, even if you >>>> specified /dev/mapper/mpatha. >>>> My problem is in SuSE, the devtmpfs is mounted on /dev by default, seems >>>> used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext4. >>> >>> What version of xfstests are you using? Do you have a >>> "README.device-mapper" file in the base directory? If not, upgrade >>> to the latest version and retry. >>> >>> $ gl -n 1 -p 0a81886 >>> commit 0a818862bb74932e15971ec8bedb55765ec3a3f6 >>> Author: Christoph Hellwig <hch@lst.de> >>> Date: Wed May 4 16:28:32 2011 +0200 >>> >>> xfstests: support post-udev device mapper nodes >>> >>> Because of udevs complaining device mapper now creates /dev/dm-N as the real >>> device nodes, and just symlinks the /dev/mapper/ names to it. This would be >>> easy if everything used the /dev/mapper clear names, but most system utilities >>> translate them back to the /dev/mapper/ names and thus confuse various test >>> cases. Add support to _is_block_dev to read symlinks, and add documentation >>> on how to run xfstests on device mapper volumes. >>> >>> Signed-off-by: Christoph Hellwig <hch@lst.de> >>> Reviewed-by: Alex Elder <aelder@sgi.com> >>> >>> Cheers, >>> >>> Dave. >>> >> >> Recent "realpath" changes also went in: >> >> b03c662399956609934ff063e9064e15dc7459ac xfstests: fix to build src/realpath and the correct the existence of target devices >> d5ea873fcbf00b841f0511a26fb341364a5c6425 xfstests: resolve symlinked devices to real paths >> >> so either of those could have broken and/or fixed it for you :) > > Yup, those are almost certainly the patches that broke device mapper > support. There' aren't changes to common.rc, so I didn't notice them. > They basically override the fix that Christoph made to support > /dev/mapper links properly. > > I'd suggest a revert is in order, the two patches above were part > of Rich's hovering of old, unreviewed patches. This problem was > already fixed in a different way by Christoph, so adding these > patches was wrong. Fine with me ... Ryan, can you test w/o those, and if it works - Rich, can you revert those please? -Eric > Cheers, > > Dave. > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to run xfstests against multipath disks on SuSE? 2012-11-27 20:37 ` Eric Sandeen @ 2012-11-27 20:55 ` Rich Johnston 0 siblings, 0 replies; 9+ messages in thread From: Rich Johnston @ 2012-11-27 20:55 UTC (permalink / raw) To: Eric Sandeen Cc: Dave Chinner, Lukáš Czerner, Ryan Wang, linux-ext4, Theodore Ts'o, xfs On 11/27/2012 02:37 PM, Eric Sandeen wrote: > On 11/27/12 2:35 PM, Dave Chinner wrote: >> On Tue, Nov 27, 2012 at 11:08:30AM -0600, Eric Sandeen wrote: >>> On 11/26/12 9:14 PM, Dave Chinner wrote: >>>> On Tue, Nov 27, 2012 at 09:20:47AM +0800, Ryan Wang wrote: >>>>> 2012/11/26 Theodore Ts'o <tytso@mit.edu>: >>>>>> On Mon, Nov 26, 2012 at 02:43:40PM +0100, Lukáš Czerner wrote: >>>>>>>> The I checked the script common.rc, and found that it uses >>>>>>>> df to determine the filesystem type and it uses the realpath >>>>>>>> "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always >>>>>>>> shows "devtmpfs" instead of "ext4" for /dev/dm-0. >>>>>>>> >>>>>>>> I run "mount" and found that devtmpfs is mount on /dev/ on opensuse >>>>>>>> ***by default***. Even though I run "mount -t btrfs /dev/dm-0 /somedir", >>>>>>>> df still showed devtmpfs. >>>>>>>> >>>>>>>> Any ideas to kick off the xfstests? >>>>>> >>>>>> At least with the df which ships with Debian Testing, df will display >>>>>> the file system in use if it matches the device name which is >>>>>> /etc/mtab. It looks the issue is that mount is canonicalizing the >>>>>> device name to be the human friendly version: >>>>>> >>>>>> # ls -l /dev/mapper/closure-bigscratch >>>>>> 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigscratch -> ../dm-7 >>>>>> <tytso.root@closure> {/home/tytso/bin}, level 2 >>>>>> # mount /dev/dm-7 /u2 >>>>>> # df /u2 >>>>>> Filesystem 1K-blocks Used Available Use% Mounted on >>>>>> /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u2 >>>>>> # grep /u2 /etc/mtab >>>>>> /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,noquota 0 0 >>>>>> >>>>>> So the simplest solution is to just use /dev/mapper/mpatha instead of >>>>>> insisting on using /dev/dm-0. That's what I do.... >>>>> >>>>> In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, even if you >>>>> specified /dev/mapper/mpatha. >>>>> My problem is in SuSE, the devtmpfs is mounted on /dev by default, seems >>>>> used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext4. >>>> >>>> What version of xfstests are you using? Do you have a >>>> "README.device-mapper" file in the base directory? If not, upgrade >>>> to the latest version and retry. >>>> >>>> $ gl -n 1 -p 0a81886 >>>> commit 0a818862bb74932e15971ec8bedb55765ec3a3f6 >>>> Author: Christoph Hellwig <hch@lst.de> >>>> Date: Wed May 4 16:28:32 2011 +0200 >>>> >>>> xfstests: support post-udev device mapper nodes >>>> >>>> Because of udevs complaining device mapper now creates /dev/dm-N as the real >>>> device nodes, and just symlinks the /dev/mapper/ names to it. This would be >>>> easy if everything used the /dev/mapper clear names, but most system utilities >>>> translate them back to the /dev/mapper/ names and thus confuse various test >>>> cases. Add support to _is_block_dev to read symlinks, and add documentation >>>> on how to run xfstests on device mapper volumes. >>>> >>>> Signed-off-by: Christoph Hellwig <hch@lst.de> >>>> Reviewed-by: Alex Elder <aelder@sgi.com> >>>> >>>> Cheers, >>>> >>>> Dave. >>>> >>> >>> Recent "realpath" changes also went in: >>> >>> b03c662399956609934ff063e9064e15dc7459ac xfstests: fix to build src/realpath and the correct the existence of target devices >>> d5ea873fcbf00b841f0511a26fb341364a5c6425 xfstests: resolve symlinked devices to real paths >>> >>> so either of those could have broken and/or fixed it for you :) >> >> Yup, those are almost certainly the patches that broke device mapper >> support. There' aren't changes to common.rc, so I didn't notice them. >> They basically override the fix that Christoph made to support >> /dev/mapper links properly. >> >> I'd suggest a revert is in order, the two patches above were part >> of Rich's hovering of old, unreviewed patches. This problem was >> already fixed in a different way by Christoph, so adding these >> patches was wrong. > > Fine with me ... > > Ryan, can you test w/o those, and if it works - > > Rich, can you revert those please? Sure, I will wait to hear from Ryan first. > > -Eric > >> Cheers, >> >> Dave. >> > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-11-27 20:54 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-11-26 0:00 How to run xfstests against multipath disks on SuSE? Ryan Wang 2012-11-26 13:43 ` Lukáš Czerner 2012-11-26 14:55 ` Theodore Ts'o 2012-11-27 1:20 ` Ryan Wang 2012-11-27 3:14 ` Dave Chinner 2012-11-27 17:08 ` Eric Sandeen 2012-11-27 20:35 ` Dave Chinner 2012-11-27 20:37 ` Eric Sandeen 2012-11-27 20:55 ` Rich Johnston
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).