From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Cc: Eric Whitney <enwlinux@gmail.com>
Subject: [PATCH V2] ext4: include journal blocks in df overhead calcs
Date: Wed, 28 Nov 2012 15:48:24 -0600 [thread overview]
Message-ID: <50B686A8.2010101@redhat.com> (raw)
In-Reply-To: <50B67949.60104@redhat.com>
To more accurately calculate overhead for "bsd" style
df reporting, we should count the journal blocks as
overhead as well.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Tested-by: Eric Whitney <enwlinux@gmail.com>
---
V2: I guess s_overhead _is_ in clusters, so do
that conversion after all. Ted, if I'm wrong, you
can pick the other patch ;)
Editorial/soapbox:
TBH it's hard to keep track of what fields are
now stored as "clusters" not blocks . . .
Esp. when we do things like use local vars named "blk" -
blks = count_overhead(sb, i, buf);
but count_overhead() returns *clusters*, so it's
really quite confusing to keep it all straight.
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 80928f7..b441daa 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3229,6 +3229,10 @@ int ext4_calculate_overhead(struct super_block *sb)
memset(buf, 0, PAGE_SIZE);
cond_resched();
}
+ /* Add the journal blocks as well */
+ if (sbi->s_journal)
+ overhead += EXT4_B2C(sbi, sbi->s_journal->j_maxlen);
+
sbi->s_overhead = overhead;
smp_wmb();
free_page((unsigned long) buf);
next prev parent reply other threads:[~2012-11-28 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 20:51 [PATCH] ext4: include journal blocks in df overhead calcs Eric Sandeen
2012-11-28 21:48 ` Eric Sandeen [this message]
2012-12-25 18:57 ` [PATCH V2] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B686A8.2010101@redhat.com \
--to=sandeen@redhat.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).