From: Tao Ma <tm@tao.ma>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Tao Ma <boyu.mt@taobao.com>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [ext4:dev 37/63] fs/ext4/inline.c:268:19: error: 'empty_zero_page' undeclared
Date: Tue, 11 Dec 2012 10:25:37 +0800 [thread overview]
Message-ID: <50C699A1.10502@tao.ma> (raw)
In-Reply-To: <50c65c00.3GZ66LxGua+Gl+1Q%fengguang.wu@intel.com>
On 12/11/2012 06:02 AM, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> head: 9a4c8019471386c6fb039ae9e30f5216b6b55a9e
> commit: 67cf5b09a46f72e048501b84996f2f77bc42e947 [37/63] ext4: add the basic function for inline data support
> config: make ARCH=sparc allyesconfig
>
> All error/warnings:
>
> fs/ext4/inline.c: In function 'ext4_create_inline_data':
> fs/ext4/inline.c:268:19: error: 'empty_zero_page' undeclared (first use in this function)
> fs/ext4/inline.c:268:19: note: each undeclared identifier is reported only once for each function it appears in
> fs/ext4/inline.c: At top level:
> fs/ext4/inline.c:164:12: warning: 'ext4_read_inline_data' defined but not used [-Wunused-function]
uh, in sparc, we don't have empty_zero_page? I just want to create an
inline data file without allocating a buffer with the specified length.
So maybe I have to do the kzalloc thing then. :(
Thanks
Tao
>
> vim +268 +/empty_zero_page fs/ext4/inline.c
>
> 67cf5b09 Tao Ma 2012-12-10 262
> 67cf5b09 Tao Ma 2012-12-10 263 error = ext4_journal_get_write_access(handle, is.iloc.bh);
> 67cf5b09 Tao Ma 2012-12-10 264 if (error)
> 67cf5b09 Tao Ma 2012-12-10 265 goto out;
> 67cf5b09 Tao Ma 2012-12-10 266
> 67cf5b09 Tao Ma 2012-12-10 267 if (len > EXT4_MIN_INLINE_DATA_SIZE) {
> 67cf5b09 Tao Ma 2012-12-10 @268 value = (void *)empty_zero_page;
> 67cf5b09 Tao Ma 2012-12-10 269 len -= EXT4_MIN_INLINE_DATA_SIZE;
> 67cf5b09 Tao Ma 2012-12-10 270 } else {
> 67cf5b09 Tao Ma 2012-12-10 271 value = "";
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> Fengguang Wu, Yuanhan Liu Intel Corporation
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-12-11 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 22:02 [ext4:dev 37/63] fs/ext4/inline.c:268:19: error: 'empty_zero_page' undeclared kbuild test robot
2012-12-11 2:25 ` Tao Ma [this message]
2012-12-11 5:12 ` Theodore Ts'o
2012-12-11 5:17 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C699A1.10502@tao.ma \
--to=tm@tao.ma \
--cc=boyu.mt@taobao.com \
--cc=fengguang.wu@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).