From: Tao Ma <tm@tao.ma>
To: Guo Chao <yan@linux.vnet.ibm.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH 3/3] ext4: remove duplicate assignment in ext4_init_new_dir()
Date: Sat, 05 Jan 2013 16:05:31 +0800 [thread overview]
Message-ID: <50E7DECB.7080707@tao.ma> (raw)
In-Reply-To: <1357371781-18194-3-git-send-email-yan@linux.vnet.ibm.com>
On 01/05/2013 03:43 PM, Guo Chao wrote:
> It should be a typo unless I miss something.
>
> Cc: Tao Ma <boyu.mt@taobao.com>
> Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
oh, you are right. Thanks for the fix. And I really can't recall how I
messed this up.
Acked-by: Tao Ma <boyu.mt@taobao.com>
> ---
> fs/ext4/namei.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index e249a47..db3b1e9 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2368,7 +2368,6 @@ static int ext4_init_new_dir(handle_t *handle, struct inode *dir,
> }
>
> inode->i_size = EXT4_I(inode)->i_disksize = blocksize;
> - dir_block = ext4_bread(handle, inode, 0, 1, &err);
> if (!(dir_block = ext4_bread(handle, inode, 0, 1, &err))) {
> if (!err) {
> err = -EIO;
>
next prev parent reply other threads:[~2013-01-05 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 7:42 [PATCH 1/3] ext4: report error if things go wrong when do checksum Guo Chao
2013-01-05 7:43 ` [PATCH 2/3] ext4: release buffer in failed path in dx_probe() Guo Chao
2013-01-05 19:41 ` Darrick J. Wong
2013-01-07 4:24 ` Theodore Ts'o
2013-01-05 7:43 ` [PATCH 3/3] ext4: remove duplicate assignment in ext4_init_new_dir() Guo Chao
2013-01-05 8:05 ` Tao Ma [this message]
2013-01-07 4:37 ` Theodore Ts'o
2013-01-05 19:50 ` [PATCH 1/3] ext4: report error if things go wrong when do checksum Darrick J. Wong
2013-01-06 2:37 ` Guo Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E7DECB.7080707@tao.ma \
--to=tm@tao.ma \
--cc=boyu.mt@taobao.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).