From: "Cristian Rodríguez" <crrodriguez@opensuse.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] lib/ext2fs/bitops.h: Use the optmized/documented byteswapping routines
Date: Mon, 14 Jan 2013 22:07:18 -0300 [thread overview]
Message-ID: <50F4ABC6.6080001@opensuse.org> (raw)
In-Reply-To: <20130114141356.GA12052@thunk.org>
On 01/14/2013 11:13 AM, Theodore Ts'o wrote:
> On Sat, Jan 12, 2013 at 04:32:25PM -0300, Cristian Rodríguez wrote:
>> In x86, it will not make much difference but other targets that
>> are not covered by the old code will be able to generate better code.
>>
>> Signed-off-by: Cristian Rodríguez <crrodriguez@opensuse.org>
>
> The problem is that bswap_{16,32,64}() and the existence of
> <byteswap.h> is not guaranted by any standard that I'm not aware of.
> A quick Google search indicates that it's not available for the
> following platforms:
>
> * Mac OS X 10.5
> * FreeBSD 6.0
> * NetBSD 5.0
> * OpenBSD 3.8
> * Minix 3.1.8
> * AIX 5.1
> * HP-UX 11
> * IRIX 6.5
> * OSF/1 5.1
> * Solaris 11 2011-11
> * Cygwin
> * mingw
> * MSVC 9
> * Interix 3.5
> * BeOS
>
> So the only way we could use bswap_{16,32,64} if there is a proper
> configure.in test for them.
The code does not compile anyway at least in mingw (I just tried) and
probably in several other targets anyway.. with or without my patch :-)
I wonder *where* the developers of this other systems are and if they
are willing to submit any improvement or fixes for the software.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-15 1:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 19:32 [PATCH] lib/ext2fs/bitops.h: Use the optmized/documented byteswapping routines Cristian Rodríguez
2013-01-14 14:13 ` Theodore Ts'o
2013-01-14 14:20 ` Theodore Ts'o
2013-01-14 15:33 ` Cristian Rodríguez
2013-01-14 21:56 ` Theodore Ts'o
2013-01-15 1:07 ` Cristian Rodríguez [this message]
2013-01-15 2:05 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F4ABC6.6080001@opensuse.org \
--to=crrodriguez@opensuse.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).