From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
gnehzuil.liu@gmail.com
Subject: Re: [PATCH 2/5] mke2fs: the -g option will now specify the clusters per block group
Date: Tue, 15 Jan 2013 09:10:41 -0600 [thread overview]
Message-ID: <50F57171.6030701@redhat.com> (raw)
In-Reply-To: <1358210232-30578-2-git-send-email-tytso@mit.edu>
On 1/14/13 6:37 PM, Theodore Ts'o wrote:
> If bigalloc is enabled, then -g will specify the clusters per block
> group. (If bigalloc is not enabled, then a cluster == a block, so the
> meaning of -g is not changed.)
This should be clearly documented in the man page as well, I think.
-Eric
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
> misc/mke2fs.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 75d0e48..5cb49b3 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1962,6 +1962,15 @@ profile_error:
> }
> }
>
> + /*
> + * If the bigalloc feature is enabled, then the -g option will
> + * specify the number of clusters per group.
> + */
> + if (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) {
> + fs_param.s_clusters_per_group = fs_param.s_blocks_per_group;
> + fs_param.s_blocks_per_group = 0;
> + }
> +
> if (inode_size == 0)
> inode_size = get_int_from_profile(fs_types, "inode_size", 0);
> if (!flex_bg_size && (fs_param.s_feature_incompat &
>
next prev parent reply other threads:[~2013-01-15 15:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 9:08 [PATCH 1/3] mke2fs: indicate bigalloc feature explicity when cluster-size is enabled Zheng Liu
2013-01-13 9:08 ` [PATCH 2/3] mke2fs: reduce the range of cluster-size Zheng Liu
2013-01-14 17:41 ` Andreas Dilger
2013-01-14 21:03 ` Theodore Ts'o
2013-01-14 21:07 ` Andreas Dilger
2013-01-14 21:10 ` Theodore Ts'o
2013-01-15 0:37 ` [PATCH 1/5] mke2fs: enforce that the cluster size must be less that the block size Theodore Ts'o
2013-01-15 0:37 ` [PATCH 2/5] mke2fs: the -g option will now specify the clusters per block group Theodore Ts'o
2013-01-15 15:10 ` Eric Sandeen [this message]
2013-01-15 19:05 ` Theodore Ts'o
2013-01-15 15:22 ` Zheng Liu
2013-01-15 0:37 ` [PATCH 3/5] libe2p: teach parse_num_blocks2() to return bytes if log_block_size < 0 Theodore Ts'o
2013-01-15 15:23 ` Zheng Liu
2013-01-15 0:37 ` [PATCH 4/5] mke2fs: teach mke2fs to understand -b 4k and -C 256M Theodore Ts'o
2013-01-15 15:11 ` Eric Sandeen
2013-01-15 15:13 ` Eric Sandeen
2013-01-15 15:24 ` Zheng Liu
2013-01-15 0:37 ` [PATCH 5/5] libext2fs: avoid 32-bit overflow in ext2fs_initialize with a 512M cluster size Theodore Ts'o
2013-01-15 15:33 ` Zheng Liu
2013-01-15 15:36 ` Zheng Liu
2013-01-15 19:10 ` Theodore Ts'o
2013-01-16 1:49 ` Zheng Liu
2013-01-15 0:41 ` [PATCH 1/5] mke2fs: enforce that the cluster size must be less that the block size Theodore Ts'o
2013-01-15 15:22 ` Zheng Liu
2013-01-13 9:08 ` [PATCH 3/3] mke2fs: document bigalloc and cluster-size Zheng Liu
2013-01-15 3:10 ` Theodore Ts'o
2013-01-15 19:12 ` Theodore Ts'o
2013-01-15 19:46 ` Phillip Susi
2013-01-15 19:57 ` Theodore Ts'o
2013-01-15 20:38 ` Phillip Susi
2013-01-15 22:28 ` Theodore Ts'o
2013-01-14 20:28 ` [PATCH 1/3] mke2fs: indicate bigalloc feature explicity when cluster-size is enabled Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F57171.6030701@redhat.com \
--to=sandeen@redhat.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).