From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
gnehzuil.liu@gmail.com
Subject: Re: [PATCH 4/5] mke2fs: teach mke2fs to understand -b 4k and -C 256M
Date: Tue, 15 Jan 2013 09:13:24 -0600 [thread overview]
Message-ID: <50F57214.3050101@redhat.com> (raw)
In-Reply-To: <50F571B3.8040500@redhat.com>
On 1/15/13 9:11 AM, Eric Sandeen wrote:
> On 1/14/13 6:37 PM, Theodore Ts'o wrote:
>> The -b and -C options now use parse_num_blocks2() insteda of strtol,
>> so that users can specify -C 256M instead of the much less convenient
>> -C 268435456.
>
> Hm and -C isn't in the manpage at all.
>
> Seems like the mke2fs manpage needs an update for bigalloc?
I'm sorry, I see that patch has already been sent. I'll catch
up with my email, now. :(
-Eric
> -Eric
>
>> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>> ---
>> misc/mke2fs.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
>> index 5cb49b3..c16ab33 100644
>> --- a/misc/mke2fs.c
>> +++ b/misc/mke2fs.c
>> @@ -1324,10 +1324,10 @@ profile_error:
>> "b:cg:i:jl:m:no:qr:s:t:vC:DE:FG:I:J:KL:M:N:O:R:ST:U:V")) != EOF) {
>> switch (c) {
>> case 'b':
>> - blocksize = strtol(optarg, &tmp, 0);
>> + blocksize = parse_num_blocks2(optarg, -1);
>> b = (blocksize > 0) ? blocksize : -blocksize;
>> if (b < EXT2_MIN_BLOCK_SIZE ||
>> - b > EXT2_MAX_BLOCK_SIZE || *tmp) {
>> + b > EXT2_MAX_BLOCK_SIZE) {
>> com_err(program_name, 0,
>> _("invalid block size - %s"), optarg);
>> exit(1);
>> @@ -1345,9 +1345,9 @@ profile_error:
>> cflag++;
>> break;
>> case 'C':
>> - cluster_size = strtoul(optarg, &tmp, 0);
>> + cluster_size = parse_num_blocks2(optarg, -1);
>> if (cluster_size <= EXT2_MIN_CLUSTER_SIZE ||
>> - cluster_size > EXT2_MAX_CLUSTER_SIZE || *tmp) {
>> + cluster_size > EXT2_MAX_CLUSTER_SIZE) {
>> com_err(program_name, 0,
>> _("invalid cluster size - %s"),
>> optarg);
>>
>
next prev parent reply other threads:[~2013-01-15 15:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 9:08 [PATCH 1/3] mke2fs: indicate bigalloc feature explicity when cluster-size is enabled Zheng Liu
2013-01-13 9:08 ` [PATCH 2/3] mke2fs: reduce the range of cluster-size Zheng Liu
2013-01-14 17:41 ` Andreas Dilger
2013-01-14 21:03 ` Theodore Ts'o
2013-01-14 21:07 ` Andreas Dilger
2013-01-14 21:10 ` Theodore Ts'o
2013-01-15 0:37 ` [PATCH 1/5] mke2fs: enforce that the cluster size must be less that the block size Theodore Ts'o
2013-01-15 0:37 ` [PATCH 2/5] mke2fs: the -g option will now specify the clusters per block group Theodore Ts'o
2013-01-15 15:10 ` Eric Sandeen
2013-01-15 19:05 ` Theodore Ts'o
2013-01-15 15:22 ` Zheng Liu
2013-01-15 0:37 ` [PATCH 3/5] libe2p: teach parse_num_blocks2() to return bytes if log_block_size < 0 Theodore Ts'o
2013-01-15 15:23 ` Zheng Liu
2013-01-15 0:37 ` [PATCH 4/5] mke2fs: teach mke2fs to understand -b 4k and -C 256M Theodore Ts'o
2013-01-15 15:11 ` Eric Sandeen
2013-01-15 15:13 ` Eric Sandeen [this message]
2013-01-15 15:24 ` Zheng Liu
2013-01-15 0:37 ` [PATCH 5/5] libext2fs: avoid 32-bit overflow in ext2fs_initialize with a 512M cluster size Theodore Ts'o
2013-01-15 15:33 ` Zheng Liu
2013-01-15 15:36 ` Zheng Liu
2013-01-15 19:10 ` Theodore Ts'o
2013-01-16 1:49 ` Zheng Liu
2013-01-15 0:41 ` [PATCH 1/5] mke2fs: enforce that the cluster size must be less that the block size Theodore Ts'o
2013-01-15 15:22 ` Zheng Liu
2013-01-13 9:08 ` [PATCH 3/3] mke2fs: document bigalloc and cluster-size Zheng Liu
2013-01-15 3:10 ` Theodore Ts'o
2013-01-15 19:12 ` Theodore Ts'o
2013-01-15 19:46 ` Phillip Susi
2013-01-15 19:57 ` Theodore Ts'o
2013-01-15 20:38 ` Phillip Susi
2013-01-15 22:28 ` Theodore Ts'o
2013-01-14 20:28 ` [PATCH 1/3] mke2fs: indicate bigalloc feature explicity when cluster-size is enabled Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F57214.3050101@redhat.com \
--to=sandeen@redhat.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).