From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wang Shilong Subject: [PATCH] Ext4: remove a useless check for the function ext4_data_block_valid Date: Sat, 26 Jan 2013 14:57:59 -0800 Message-ID: <51045F77.5000106@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org To: tytso@mit.edu Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:55156 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990Ab3AZGz7 (ORCPT ); Sat, 26 Jan 2013 01:55:59 -0500 Received: by mail-pa0-f45.google.com with SMTP id bg2so658161pad.4 for ; Fri, 25 Jan 2013 22:55:58 -0800 (PST) Sender: linux-ext4-owner@vger.kernel.org List-ID: From: Wang Shilong Because it is no doubt 'start_blk + count < start_blk' always comes to false. It is useless to have this check,remove it. Signed-off-by: Wang Shilong --- fs/ext4/block_validity.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index 3f11656..5ffce82 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -226,7 +226,6 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk, struct rb_node *n = sbi->system_blks.rb_node; if ((start_blk <= le32_to_cpu(sbi->s_es->s_first_data_block)) || - (start_blk + count < start_blk) || (start_blk + count > ext4_blocks_count(sbi->s_es))) { sbi->s_es->s_last_error_block = cpu_to_le64(start_blk); return 0; -- 1.7.11.7