* [PATCH 1/2] Ext2: remove a useless check for the function ext2_free_blocks
@ 2013-01-26 22:58 Wang Shilong
0 siblings, 0 replies; 3+ messages in thread
From: Wang Shilong @ 2013-01-26 22:58 UTC (permalink / raw)
To: jack; +Cc: linux-ext4
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Because 'block + count < block' always comes to false, it is useles to
have this check,just remove it.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/balloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 2616d0e..081929c 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -498,7 +498,6 @@ void ext2_free_blocks (struct inode * inode, unsigned long block,
unsigned freed = 0, group_freed;
if (block < le32_to_cpu(es->s_first_data_block) ||
- block + count < block ||
block + count > le32_to_cpu(es->s_blocks_count)) {
ext2_error (sb, "ext2_free_blocks",
"Freeing blocks not in datazone - "
-- 1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 1/2] Ext2: remove a useless check for the function ext2_free_blocks
@ 2012-01-26 22:55 Wang Shilong
0 siblings, 0 replies; 3+ messages in thread
From: Wang Shilong @ 2012-01-26 22:55 UTC (permalink / raw)
To: jack; +Cc: linux-ext4
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Because 'block + count < block' always comes to false, it is useles to
have this check,just remove it.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/balloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 2616d0e..081929c 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -498,7 +498,6 @@ void ext2_free_blocks (struct inode * inode, unsigned long block,
unsigned freed = 0, group_freed;
if (block < le32_to_cpu(es->s_first_data_block) ||
- block + count < block ||
block + count > le32_to_cpu(es->s_blocks_count)) {
ext2_error (sb, "ext2_free_blocks",
"Freeing blocks not in datazone - "
-- 1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 1/2] Ext2: remove a useless check for the function ext2_free_blocks
@ 2011-01-26 22:47 Wang Shilong
0 siblings, 0 replies; 3+ messages in thread
From: Wang Shilong @ 2011-01-26 22:47 UTC (permalink / raw)
To: jack; +Cc: linux-ext4
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Because 'block + count < block' always comes to false, it is useles to
have this check,just remove it.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/balloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 2616d0e..081929c 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -498,7 +498,6 @@ void ext2_free_blocks (struct inode * inode, unsigned long block,
unsigned freed = 0, group_freed;
if (block < le32_to_cpu(es->s_first_data_block) ||
- block + count < block ||
block + count > le32_to_cpu(es->s_blocks_count)) {
ext2_error (sb, "ext2_free_blocks",
"Freeing blocks not in datazone - "
-- 1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-26 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-26 22:58 [PATCH 1/2] Ext2: remove a useless check for the function ext2_free_blocks Wang Shilong
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 22:55 Wang Shilong
2011-01-26 22:47 Wang Shilong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).