From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Dave Jones <davej@redhat.com>,
"gnehzuil.liu" <gnehzuil.liu@gmail.com>,
Zheng Liu <wenqing.lz@taobao.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: optimize ext4_es_shrink()
Date: Fri, 01 Mar 2013 10:40:37 -0600 [thread overview]
Message-ID: <5130DA05.4070601@redhat.com> (raw)
In-Reply-To: <20130301050029.GB4452@thunk.org>
On 2/28/13 11:00 PM, Theodore Ts'o wrote:
> When the system is under memory pressure, ext4_es_srhink() will get
> called very often. So optimize returning the number of items in the
> file system's extent status cache by keeping a per-filesystem count,
> instead of calculating it each time by scanning all of the inodes in
> the extent status cache.
>
> Also rename the slab used for the extent status cache to be
> "ext4_extent_status" so it's obviousl the slab in question is created
> by ext4.
Certainly better than walking an arbitrarily long list. :)
So:
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
I was wondering a couple things, though -
1) should this one be scaled by the vfs_cache_pressure sysctl?
2) Also, given that this is only for shrinker accounting, do we need the
precision of the atomic counter? I see that quota uses a per-cpu counter.
Would a percpu counter be any more efficient? I'll follow
w/ a patch.
-Eric
next prev parent reply other threads:[~2013-03-01 16:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 20:39 [GIT PULL] ext4 updates for 3.9 Theodore Ts'o
2013-02-27 12:47 ` Markus Trippelsdorf
2013-02-27 15:34 ` Theodore Ts'o
2013-02-27 15:44 ` Markus Trippelsdorf
2013-02-27 17:01 ` Markus Trippelsdorf
2013-02-27 17:10 ` gnehzuil.liu
2013-02-27 17:22 ` Markus Trippelsdorf
2013-02-27 17:38 ` gnehzuil.liu
2013-02-27 17:45 ` Markus Trippelsdorf
2013-02-27 17:52 ` Linus Torvalds
2013-02-27 18:49 ` Theodore Ts'o
2013-02-27 18:56 ` Markus Trippelsdorf
2013-02-27 19:19 ` Dave Jones
2013-02-27 19:27 ` Zheng Liu
2013-02-27 19:29 ` Theodore Ts'o
2013-02-27 20:12 ` [GIT PULL URGENT] ext4 regression fix " Linus Torvalds
2013-02-27 20:15 ` Theodore Ts'o
2013-02-27 20:23 ` Linus Torvalds
2013-02-27 20:41 ` Borislav Petkov
2013-03-01 3:30 ` Dave Jones
2013-03-01 4:00 ` Theodore Ts'o
2013-03-01 5:00 ` [PATCH] ext4: optimize ext4_es_shrink() Theodore Ts'o
2013-03-01 16:11 ` Dave Jones
2013-03-01 16:26 ` Theodore Ts'o
2013-03-01 16:40 ` Dave Jones
2013-03-01 16:40 ` Eric Sandeen [this message]
2013-03-01 16:42 ` [PATCH] ext4: use percpu counter for extent cache count Eric Sandeen
2013-03-01 18:00 ` Theodore Ts'o
2013-03-01 18:02 ` Eric Sandeen
2013-03-02 15:26 ` Theodore Ts'o
2013-03-03 16:39 ` Zheng Liu
2013-03-04 16:11 ` Eric Sandeen
2013-03-02 19:54 ` [GIT PULL URGENT] ext4 regression fix for 3.9 Linus Torvalds
2013-03-02 23:15 ` Theodore Ts'o
2013-02-27 20:14 ` Theodore Ts'o
2013-02-27 20:58 ` [GIT PULL] ext4 updates " Dmitry Monakhov
2013-02-27 21:30 ` Theodore Ts'o
2013-03-01 15:41 ` Eric Sandeen
2013-02-28 13:18 ` Dave Chinner
2013-02-27 18:57 ` Dave Jones
2013-02-27 19:04 ` Theodore Ts'o
2013-02-27 19:11 ` Dave Jones
2013-02-27 19:19 ` Theodore Ts'o
2013-02-27 18:59 ` Zheng Liu
2013-02-27 19:06 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130DA05.4070601@redhat.com \
--to=sandeen@redhat.com \
--cc=davej@redhat.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).