From: Stephen Warren <swarren@wwwdotorg.org>
To: Chris Ball <cjb@laptop.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
"Lukáš Czerner" <lczerner@redhat.com>,
linux-ext4@vger.kernel.org, "Stephen Warren" <swarren@nvidia.com>
Subject: Re: [PATCH] mke2fs: restore verbose message for BLKDISCARD
Date: Fri, 08 Mar 2013 13:03:41 -0700 [thread overview]
Message-ID: <513A441D.1060706@wwwdotorg.org> (raw)
In-Reply-To: <87vc91zp45.fsf@octavius.laptop.org>
On 03/08/2013 12:08 PM, Chris Ball wrote:
> Hi,
>
> On Fri, Mar 08 2013, Theodore Ts'o wrote:
>> I hate to suggest this, but there's so many crappy devices out there
>> that I'm wondering if we need to figure out some way of maintaining a
>> black list of devices that don't handle discard properly.
>
> Yes, we already do that in the MMC layer. See e.g.:
>
> http://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?id=3550ccdb9d8d350e526b809bf3dd92b550a74fe1
> ("mmc: card: Skip secure erase on MoviNAND; causes unrecoverable corruption.")
Unrecoverable sounds scary. Does that just mean data corruption, or a
permanently broken device? mk2e2fs -K followed by e2fsck and mounting
luckily seems to still work OK for me:-)
FWIW, my CID is 45010053454d31364790711c665f3e00, i.e. manufacturer ID
0x45, device name SEM16G.
next prev parent reply other threads:[~2013-03-08 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 20:25 [PATCH] mke2fs: restore verbose message for BLKDISCARD Stephen Warren
2013-03-06 7:13 ` Lukáš Czerner
2013-03-07 19:47 ` Stephen Warren
2013-03-08 7:23 ` Lukáš Czerner
2013-03-08 17:18 ` Stephen Warren
2013-03-08 19:00 ` Theodore Ts'o
2013-03-08 19:06 ` Theodore Ts'o
2013-03-08 19:08 ` Chris Ball
2013-03-08 20:03 ` Stephen Warren [this message]
2013-03-08 20:12 ` Chris Ball
2013-03-11 14:08 ` Eric Sandeen
2013-03-11 14:18 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A441D.1060706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=cjb@laptop.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).