From: Rich Johnston <rjohnston@sgi.com>
To: <dsterba@suse.cz>, Eric Sandeen <sandeen@redhat.com>,
xfs-oss <xfs@oss.sgi.com>,
ext4 development <linux-ext4@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] xfstests: make defrag test 222 generic
Date: Fri, 15 Mar 2013 11:03:31 -0500 [thread overview]
Message-ID: <51434653.40808@sgi.com> (raw)
In-Reply-To: <20130315145540.GG7229@twin.jikos.cz>
On 03/15/2013 09:55 AM, David Sterba wrote:
> On Tue, Mar 12, 2013 at 11:42:50AM -0500, Eric Sandeen wrote:
>> Define a new _defrag_dir() helper which just runs noisy/debug
>> dir defrag for ext4 and/or btrfs as well, and use that in 222
>> instead of hardcoded xfs_fsr.
>
> Dir defrag on btrfs does not recurse in the given directory to defrag
> all files, but defragments the tree of the containing subvolume and the
> whole extent tree (thus needs CAP_SYS_ADMIN).
>
> This is known (and not very intuitive) behaviour, it would be better to
> add a special parameter to defrag the root and/or the extent root and
> pass it down to the ioctl via flags.
>
> Until this is implemented I suggest to use a workaround via 'find':
>
> find $dir -print -execdir $DEFRAG_PROG '{}' +
>
> Otherwise the test looks ok.
>
> david
Eric, I will make this change at commit time if you agree?
David, can I put your name as the reviewer when I do?
Thanks
--Rich
next prev parent reply other threads:[~2013-03-15 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 16:42 [PATCH] xfstests: make defrag test 222 generic Eric Sandeen
2013-03-15 14:55 ` David Sterba
2013-03-15 16:03 ` Rich Johnston [this message]
2013-03-15 16:05 ` Eric Sandeen
2013-03-27 14:53 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51434653.40808@sgi.com \
--to=rjohnston@sgi.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).