linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Perepechko <anserper@ya.ru>
To: linux-ext4@vger.kernel.org
Cc: alexey.lyashkov@gmail.com
Subject: page eviction from the buddy cache
Date: Mon, 25 Mar 2013 16:59:44 +0400	[thread overview]
Message-ID: <51504A40.6020604@ya.ru> (raw)

Hello!

Our recent investigation has found that pages from
the buddy cache are evicted too often as compared
to the expectation from their usage pattern. This
introduces additional reads during large writes under
our workload and really hurts overall performance.

ext4 uses find_get_page() and find_or_create_page()
to look for buddy cache pages, but these pages don't
get a chance to become activated until the following
lru_add_drain() call, because mark_page_accessed()
does not activate pages which are not PageLRU().

As can be found from a kprobe-based test, these pages
are often moved on the inactive LRU as a result of
shrink_inactive_list()->lru_add_drain() and immediately
evicted.

 From a quick look into linux-2.6.git, the issue seems
to exist in the current code as well.

A possible and, perhaps, non-optimal solution would be
to call lru_add_drain() each time a buddy cache page
is used.

Any other suggestions?

Thank you,
Andrew

             reply	other threads:[~2013-03-25 13:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 12:59 Andrew Perepechko [this message]
2013-03-27 15:07 ` page eviction from the buddy cache Theodore Ts'o
2013-03-27 19:24   ` Hugh Dickins
2013-03-28  5:34     ` Alexey Lyahkov
2013-04-04  1:24       ` Will Huck
2013-04-04  4:51         ` Alexey Lyahkov
2013-04-20 21:18           ` Bernd Schubert
2013-04-20 23:57             ` Theodore Ts'o
2013-04-22 12:14               ` Alexey Lyahkov
2013-04-23 12:02               ` Bernd Schubert
2013-04-23 12:27                 ` Theodore Ts'o
2013-04-23 19:57                   ` Hugh Dickins
2013-04-23 22:00                     ` Andrew Morton
2013-04-23 22:31                       ` Hugh Dickins
2013-04-24 14:26                       ` Theodore Ts'o
2013-04-24 21:41                         ` Andrew Morton
2013-04-25  8:18                           ` Alexey Lyahkov
2013-04-25 14:30                         ` Mel Gorman
2013-04-25 18:37                           ` Alexey Lyahkov
2013-04-25 22:40                             ` Mel Gorman
2013-04-26  6:03                               ` Alexey Lyahkov
2013-04-22 12:18             ` Alexey Lyahkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51504A40.6020604@ya.ru \
    --to=anserper@ya.ru \
    --cc=alexey.lyashkov@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).