From: Rich Johnston <rjohnston@sgi.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: xfs-oss <xfs@oss.sgi.com>, <linux-ext4@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: Announce re-factor all current xfstests patches request
Date: Wed, 27 Mar 2013 11:42:35 -0500 [thread overview]
Message-ID: <5153217B.5070909@sgi.com> (raw)
In-Reply-To: <20130327134606.GJ5861@thunk.org>
On 03/27/2013 08:46 AM, Theodore Ts'o wrote:
> On Wed, Mar 27, 2013 at 08:23:07AM -0500, Rich Johnston wrote:
>> All xfstest developers,
>>
>> Thanks again for all your time in submitting and reviewing patches
>> for xfstests. The latest patchset posted here:
>>
>> http://oss.sgi.com/archives/xfs/2013-03/msg00467.html
>>
>> requires all current patches to be re-factored.
>
> Given that we are now segregating patches into subdirectories, is it
> correct in the future tests should be named descriptively, instead of
> using 3 digit NNN numbers (which has been a major pain from a central
> assignment perspective)?
Yes
>
> If so, is there a suggested naming convention that is being recommended?
>
> Thanks for getting this change merged in!!
>
> - Ted
>
I suggest:
1. They should also be descriptive of the test rather than a number.
2. All lowercase letters separated by _
i.e.
something like
tests/$FSTYP/break_my_filesystem
Thanks
--Rich
next prev parent reply other threads:[~2013-03-27 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 13:23 Announce re-factor all current xfstests patches request Rich Johnston
2013-03-27 13:46 ` Theodore Ts'o
2013-03-27 16:42 ` Rich Johnston [this message]
2013-03-27 19:05 ` Theodore Ts'o
2013-03-27 20:42 ` Zach Brown
2013-03-27 20:52 ` Ben Myers
2013-03-28 0:34 ` Dave Chinner
2013-03-27 21:02 ` Dave Chinner
2013-03-27 20:54 ` Dave Chinner
2013-03-27 21:48 ` Theodore Ts'o
2013-03-28 0:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5153217B.5070909@sgi.com \
--to=rjohnston@sgi.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).