linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
	Anand Avati <avati@redhat.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH, RFC V3] ext3: add ioctl to force 32-bit hashes from indexed dirs
Date: Mon, 01 Apr 2013 14:49:00 -0500	[thread overview]
Message-ID: <5159E4AC.7050307@redhat.com> (raw)
In-Reply-To: <20130401190804.GD22443@thunk.org>

On 4/1/13 2:08 PM, Theodore Ts'o wrote:
> On Mon, Apr 01, 2013 at 01:21:51PM -0500, Eric Sandeen wrote:
>>> This would allow a bit more flexibility than just requiring that the
>>> ioctl be issued just after the opendir(), and allow it just after a
>>> call to rewinddir().
>>
>> I guess I do wonder what real-world use that might have, though.
> 
> To be honest, I can't think of one.  And if the presumption is this is
> just going to be a special case hack, maybe we shouldn't worry about
> the general-use case.
> 
> Thinking about this some more, keeping this simple might be better way
> to go.  It's not like we really want to be encouraging people to use
> this interface....
> 
> What do you think?

Urgh, I guess if we are adding an interface which will live "forever,"
we may as well make it full featured & flexible, as long as the complexity
isn't out of hand, and I don't think it will be in this case.  So I'm at
least half inclined to go ahead & allow toggling it on and off under the
right circumstances, even though it goes against what I think is my better
judgement.  ;)

-Eric

> 						- Ted
> 


  reply	other threads:[~2013-04-01 19:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 16:25 [PATCH, RFC] ext3: add ioctl to force 32-bit hashes from indexed dirs Eric Sandeen
2013-03-28 20:40 ` [PATCH, RFC V2] " Eric Sandeen
2013-03-29 11:43   ` Jan Kara
2013-04-01 15:13     ` Eric Sandeen
2013-04-01 15:33   ` [PATCH, RFC V3] " Eric Sandeen
2013-04-01 18:17     ` Theodore Ts'o
2013-04-01 18:21       ` Eric Sandeen
2013-04-01 19:08         ` Theodore Ts'o
2013-04-01 19:49           ` Eric Sandeen [this message]
2013-04-01 20:00             ` Theodore Ts'o
2013-04-01 20:05               ` Eric Sandeen
2013-04-01 20:09                 ` Theodore Ts'o
     [not found]                 ` <5159E88F.8030704-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-01 20:34                   ` Anand Avati
2013-04-05 23:05                     ` Andrew Bartlett
2013-04-05 23:28                       ` J. Bruce Fields
2013-04-05 23:26                         ` Anand Avati
2013-04-08  9:28                           ` Andrew Bartlett
2013-04-03 12:54     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5159E4AC.7050307@redhat.com \
    --to=sandeen@redhat.com \
    --cc=avati@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).