Re: [PATCH, RFC V3] ext3: add ioctl to force 32-bit hashes from indexed dirs

[Eric Sandeen <sandeen@redhat.com>]

On 4/1/13 3:00 PM, Theodore Ts'o wrote:
> On Mon, Apr 01, 2013 at 02:49:00PM -0500, Eric Sandeen wrote:
>>
>> Urgh, I guess if we are adding an interface which will live "forever,"
>> we may as well make it full featured & flexible, as long as the complexity
>> isn't out of hand, and I don't think it will be in this case.  So I'm at
>> least half inclined to go ahead & allow toggling it on and off under the
>> right circumstances, even though it goes against what I think is my better
>> judgement.  ;)
> 
> If you want to have a fully flexible interface, then we probably
> should have a way to both get and set the flag.  And from there the
> next step down the slippery slope would be to make this be a bit more
> like a fcntl-style F_GETFL/F_SETFL style interface, so we can in the
> future set and get other ext4-specific struct_file-specific flags.  :-)
> 
> I'll let you decide how far you want to go with this; I won't mind if
> you keep it with the original KISS interface, but I also won't mind if
> you want to create a somewhat more expansive interface.

Meh, let's just keep it simple then.  And I'd really like to know if
gluster still even needs this, or if their new scheme will work instead,
in  which case we should drop it - but Samba made noise about needing it too,
though I've not seen specifics, so I hate to merge it "just in case."

I put it out mostly for review so it was ready if we needed it (since
certain quarters seem anxious) ;)

-Eric



> Cheers,
> 
> 						- Ted
>