From: Kazuya Mio <k-mio@sx.jp.nec.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] mke2fs: fix force option to create filesystem on mounted device
Date: Tue, 07 May 2013 17:14:14 +0900 [thread overview]
Message-ID: <5188B7D6.8010200@sx.jp.nec.com> (raw)
In-Reply-To: <4A2A7340-F533-4C6E-B05C-39EC548A3D5F@gmail.com>
2013/04/27 6:45, Andreas Dilger wrote:
>> http://patchwork.ozlabs.org/patch/217838/
>
> Out of curiosity, is formatting a mounted filesystem something
> that you are actually trying to do, or is this just a case of
> trying to make the mke2fs usage consistent with the man page?
The purpose of this patch is the latter.
>> http://patchwork.ozlabs.org/patch/217839/
>
> I don't understand the second patch. If the user tries to format
> the /dev/loop device, then it is a "block device" and not really
> a "regular file" (i.e. the user probably knows what is going on).
> I don't think it is necessary to include the extra code and checking
> in this case. Do I misunderstand what your patch is doing?
/dev/loop device is a block device as you know, but an image file is
a regular file and you can format it.
I think we have to prevent mke2fs to in-use image file by mistake.
Regards,
Kazuya Mio
next prev parent reply other threads:[~2013-05-07 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 8:04 [PATCH 1/2] mke2fs: fix force option to create filesystem on mounted device Kazuya Mio
2013-04-25 23:58 ` Kazuya Mio
2013-04-26 21:45 ` Andreas Dilger
2013-05-07 8:14 ` Kazuya Mio [this message]
2013-05-20 4:50 ` Kazuya Mio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188B7D6.8010200@sx.jp.nec.com \
--to=k-mio@sx.jp.nec.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox