From: ashishsangwan2@gmail.com
To: tytso@mit.edu, adilger@dilger.ca
Cc: linux-ext4@vger.kernel.org,
Ashish Sangwan <a.sangwan@samsung.com>,
Namjae Jeon <namjae.jeon@samsung.com>
Subject: [PATCH] ext4: optimize extent selection for block removal in case of hole punch
Date: Fri, 24 May 2013 20:09:17 +0530 [thread overview]
Message-ID: <519f7ba2.04fc440a.06c2.ffffd589@mx.google.com> (raw)
From: Ashish Sangwan <a.sangwan@samsung.com>
Both hole punch and truncate use ext4_ext_rm_leaf for removing
blocks. Currently we choose the last extent as the starting
point for removing blocks: ex = EXT_LAST_EXTENT(eh);
This is OK for truncate but for hole punch we can optimize the
extent selection as the path is already initialized.
We could use this information to select proper starting extent.
The code change in this patch will not affect truncate as for
truncate path[depth].p_ext will always be NULL.
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
---
fs/ext4/extents.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 3676dae..7c1a5d3 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2490,7 +2490,9 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode,
return -EIO;
}
/* find where to start removing */
- ex = EXT_LAST_EXTENT(eh);
+ ex = path[depth].p_ext;
+ if (!ex)
+ ex = EXT_LAST_EXTENT(eh);
ex_ee_block = le32_to_cpu(ex->ee_block);
ex_ee_len = ext4_ext_get_actual_len(ex);
--
1.7.2.3
next reply other threads:[~2013-05-24 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 14:39 ashishsangwan2 [this message]
2013-06-18 15:40 ` [PATCH] ext4: optimize extent selection for block removal in case of hole punch Theodore Ts'o
2013-06-19 13:45 ` Ashish Sangwan
2013-06-19 14:06 ` Theodore Ts'o
2013-06-19 15:44 ` Ashish Sangwan
2013-06-23 18:43 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519f7ba2.04fc440a.06c2.ffffd589@mx.google.com \
--to=ashishsangwan2@gmail.com \
--cc=a.sangwan@samsung.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).